Issue 53405. Report PATTERN_NEVER_MATCHES_VALUE_TYPE got record patterns.

Bug: #53405
Change-Id: I139fc620f10f18ab2b44b806ab24fa09e9956f61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323685
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

Author: scheglov

pkg/analyzer/lib/src/dart/ast/ast.dart

@@ -14926,6 +14926,8 @@ final class RecordPatternImpl extends DartPatternImpl implements RecordPattern {
   @override
   final Token rightParenthesis;
 
+  bool hasDuplicateNamedField = false;
+
   RecordPatternImpl({
     required this.leftParenthesis,
     required List<PatternFieldImpl> fields,
@@ -14970,14 +14972,22 @@ final class RecordPatternImpl extends DartPatternImpl implements RecordPattern {
     ResolverVisitor resolverVisitor,
     SharedMatchContext context,
   ) {
-    resolverVisitor.analyzeRecordPattern(
+    final result = resolverVisitor.analyzeRecordPattern(
       context,
       this,
       fields: resolverVisitor.buildSharedPatternFields(
         fields,
         mustBeNamed: false,
       ),
     );
+
+    if (!hasDuplicateNamedField) {
+      resolverVisitor.checkPatternNeverMatchesValueType(
+        context: context,
+        pattern: this,
+        requiredType: result.requiredType,
+      );
+    }
   }
 
   @override

pkg/analyzer/lib/src/dart/resolver/shared_type_analyzer.dart

@@ -83,6 +83,9 @@ class SharedTypeAnalyzerErrors
     required covariant SharedPatternField original,
     required covariant SharedPatternField duplicate,
   }) {
+    if (objectOrRecordPattern is RecordPatternImpl) {
+      objectOrRecordPattern.hasDuplicateNamedField = true;
+    }
     _errorReporter.reportError(
       DiagnosticFactory().duplicatePatternField(
         source: _errorReporter.source,

pkg/analyzer/test/src/dart/resolution/record_pattern_test.dart

@@ -305,7 +305,8 @@ void f(() x) {
   }
 }
 ''', [
-      error(HintCode.UNUSED_LOCAL_VARIABLE, 47, 1),
+      error(WarningCode.PATTERN_NEVER_MATCHES_VALUE_TYPE, 39, 10),
+      error(WarningCode.UNUSED_LOCAL_VARIABLE, 47, 1),
     ]);
     final node = findNode.singleGuardedPattern.pattern;
     assertResolvedNodeText(node, r'''
@@ -338,7 +339,8 @@ void f(() x) {
   }
 }
 ''', [
-      error(HintCode.UNUSED_LOCAL_VARIABLE, 46, 1),
+      error(WarningCode.PATTERN_NEVER_MATCHES_VALUE_TYPE, 39, 9),
+      error(WarningCode.UNUSED_LOCAL_VARIABLE, 46, 1),
     ]);
     final node = findNode.singleGuardedPattern.pattern;
     assertResolvedNodeText(node, r'''
@@ -369,7 +371,8 @@ void f(({int b}) x) {
   }
 }
 ''', [
-      error(HintCode.UNUSED_LOCAL_VARIABLE, 53, 1),
+      error(WarningCode.PATTERN_NEVER_MATCHES_VALUE_TYPE, 46, 9),
+      error(WarningCode.UNUSED_LOCAL_VARIABLE, 53, 1),
     ]);
     final node = findNode.singleGuardedPattern.pattern;
     assertResolvedNodeText(node, r'''
@@ -400,7 +403,8 @@ void f(({int a, int b}) x) {
   }
 }
 ''', [
-      error(HintCode.UNUSED_LOCAL_VARIABLE, 60, 1),
+      error(WarningCode.PATTERN_NEVER_MATCHES_VALUE_TYPE, 53, 9),
+      error(WarningCode.UNUSED_LOCAL_VARIABLE, 60, 1),
     ]);
     final node = findNode.singleGuardedPattern.pattern;
     assertResolvedNodeText(node, r'''
@@ -432,7 +436,8 @@ void f(() x) {
   }
 }
 ''', [
-      error(HintCode.UNUSED_LOCAL_VARIABLE, 44, 1),
+      error(WarningCode.PATTERN_NEVER_MATCHES_VALUE_TYPE, 39, 8),
+      error(WarningCode.UNUSED_LOCAL_VARIABLE, 44, 1),
     ]);
     final node = findNode.singleGuardedPattern.pattern;
     assertResolvedNodeText(node, r'''
@@ -461,7 +466,8 @@ void f((int, String) x) {
   }
 }
 ''', [
-      error(HintCode.UNUSED_LOCAL_VARIABLE, 55, 1),
+      error(WarningCode.PATTERN_NEVER_MATCHES_VALUE_TYPE, 50, 8),
+      error(WarningCode.UNUSED_LOCAL_VARIABLE, 55, 1),
     ]);
     final node = findNode.singleGuardedPattern.pattern;
     assertResolvedNodeText(node, r'''
@@ -561,7 +567,8 @@ void f(({int foo}) x) {
   }
 }
 ''', [
-      error(HintCode.UNUSED_LOCAL_VARIABLE, 58, 1),
+      error(WarningCode.PATTERN_NEVER_MATCHES_VALUE_TYPE, 48, 12),
+      error(WarningCode.UNUSED_LOCAL_VARIABLE, 58, 1),
     ]);
     final node = findNode.singleGuardedPattern.pattern;
     assertResolvedNodeText(node, r'''
@@ -625,6 +632,7 @@ void f(({int foo}) x) {
   }
 }
 ''', [
+      error(WarningCode.PATTERN_NEVER_MATCHES_VALUE_TYPE, 48, 5),
       error(CompileTimeErrorCode.MISSING_NAMED_PATTERN_FIELD_NAME, 49, 3),
     ]);
     final node = findNode.singleGuardedPattern.pattern;

pkg/analyzer/test/src/diagnostics/pattern_never_matches_value_type_test.dart

@@ -1040,6 +1040,34 @@ void f(String x) {
     ]);
   }
 
+  test_refutable_pattern_reportPattern_match() async {
+    await assertErrorsInCode('''
+void f((int,) x) {
+  switch (x) {
+    case (int f,):
+      break;
+  }
+}
+''', [
+      error(WarningCode.UNUSED_LOCAL_VARIABLE, 48, 1),
+    ]);
+  }
+
+  test_refutable_pattern_reportPattern_notMatch() async {
+    await assertErrorsInCode('''
+void f((int,) x) {
+  switch (x) {
+    case (int f1, int f2):
+      break;
+  }
+}
+''', [
+      error(WarningCode.PATTERN_NEVER_MATCHES_VALUE_TYPE, 43, 16),
+      error(WarningCode.UNUSED_LOCAL_VARIABLE, 48, 2),
+      error(WarningCode.UNUSED_LOCAL_VARIABLE, 56, 2),
+    ]);
+  }
+
   test_refutable_pattern_wildcard_match() async {
     await assertNoErrorsInCode('''
 void f(num x) {