Remove left-over patch declarations for List constructor.

This CL replaces https://dart-review.googlesource.com/c/sdk/+/296900

The `List` constructor is removed in Dart 3.0.
Some of the `@patch` implementations were not removed.

This is *high priority*. It seems the left-over `@patch factory List` constructor did not cause any errors, instead it *added* a constructor  to `List` that can be used in web compiled code. Even if `List` doesn't have such a constructor in the SDK code proper.
The VM and analyzer will say the invocation is an error, but dart2js happily compiles it and runs.

(It used to be that patches couldn't add public members, that security seems to have been removed.)

Also removes code which tries to detect "the unnamed List constructor",
which is no longer a thing, and a number of invocations of the constructor, where it's not clear that the test is aware that the constructor no longer exists, and is not marked as `@dart=2.x` with x < 12.

TEST=ci

Change-Id: I4ffaf3ae2c4e75ca06e7ba0bf19187b6376f3888
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/297100
Reviewed-by: Brian Quinlan <[email protected]>
Reviewed-by: Nate Bosch <[email protected]>
Reviewed-by: Sigmund Cherem <[email protected]>
Commit-Queue: Stephen Adams <[email protected]>

Author: rakudrama

pkg/compiler/lib/src/common/elements.dart

@@ -1107,14 +1107,6 @@ class KCommonElements extends CommonElements {
 class JCommonElements extends CommonElements {
   JCommonElements(super.dartTypes, super.env);
 
-  /// Returns `true` if [element] is the unnamed constructor of `List`.
-  ///
-  /// This will not resolve the constructor if it hasn't been seen yet during
-  /// compilation.
-  bool isUnnamedListConstructor(ConstructorEntity element) =>
-      (element.name == '' && element.enclosingClass == listClass) ||
-      (element.name == 'list' && element.enclosingClass == jsArrayClass);
-
   /// Returns `true` if [element] is the named constructor of `List`,
   /// e.g. `List.of`.
   ///

pkg/compiler/lib/src/inferrer/builder.dart

@@ -1385,24 +1385,6 @@ class KernelTypeGraphBuilder extends ir.Visitor<TypeInformation?>
 
     var commonElements = _elementMap.commonElements;
 
-    if (commonElements.isUnnamedListConstructor(constructor)) {
-      // We have `new List(...)`.
-      if (arguments.positional.isEmpty && arguments.named.isEmpty) {
-        // We have `new List()`.
-        return _inferrer.concreteTypes.putIfAbsent(
-            node,
-            () => _types.allocateList(_types.growableListType, node,
-                _analyzedMember, _types.nonNullEmpty(), 0));
-      } else {
-        // We have `new List(len)`.
-        final length = _findLength(arguments);
-        return _inferrer.concreteTypes.putIfAbsent(
-            node,
-            () => _types.allocateList(_types.fixedListType, node,
-                _analyzedMember, _types.nullType, length));
-      }
-    }
-
     if (commonElements.isNamedListConstructor('filled', constructor)) {
       // We have something like `List.filled(len, fill)`.
       final length = _findLength(arguments);

pkg/compiler/lib/src/inferrer_experimental/builder.dart

@@ -1385,24 +1385,6 @@ class KernelTypeGraphBuilder extends ir.Visitor<TypeInformation?>
 
     var commonElements = _elementMap.commonElements;
 
-    if (commonElements.isUnnamedListConstructor(constructor)) {
-      // We have `new List(...)`.
-      if (arguments.positional.isEmpty && arguments.named.isEmpty) {
-        // We have `new List()`.
-        return _inferrer.concreteTypes.putIfAbsent(
-            node,
-            () => _types.allocateList(_types.growableListType, node,
-                _analyzedMember, _types.nonNullEmpty(), 0));
-      } else {
-        // We have `new List(len)`.
-        final length = _findLength(arguments);
-        return _inferrer.concreteTypes.putIfAbsent(
-            node,
-            () => _types.allocateList(_types.fixedListType, node,
-                _analyzedMember, _types.nullType, length));
-      }
-    }
-
     if (commonElements.isNamedListConstructor('filled', constructor)) {
       // We have something like `List.filled(len, fill)`.
       final length = _findLength(arguments);

pkg/compiler/lib/src/ssa/builder.dart

@@ -4256,27 +4256,6 @@ class KernelSsaGraphBuilder extends ir.Visitor<void> with ir.VisitorVoidMixin {
       AbstractValue typeMask,
       List<HInstruction> arguments,
       SourceInformation? sourceInformation) {
-    // Recognize `List()` and `List(n)`.
-    if (_commonElements.isUnnamedListConstructor(function)) {
-      if (invocation.arguments.named.isEmpty) {
-        int argumentCount = invocation.arguments.positional.length;
-        if (argumentCount == 0) {
-          // `List()` takes no arguments, `JSArray.list()` takes a sentinel.
-          assert(arguments.length == 0 || arguments.length == 1,
-              '\narguments: $arguments\n');
-          _handleInvokeLegacyGrowableListFactoryConstructor(
-              invocation, function, typeMask, arguments, sourceInformation);
-          return;
-        }
-        if (argumentCount == 1) {
-          assert(arguments.length == 1);
-          _handleInvokeLegacyFixedListFactoryConstructor(
-              invocation, function, typeMask, arguments, sourceInformation);
-          return;
-        }
-      }
-    }
-
     // Recognize `JSArray<E>.typed(allocation)`.
     if (function == _commonElements.jsArrayTypedConstructor) {
       if (invocation.arguments.named.isEmpty) {
@@ -4400,98 +4379,6 @@ class KernelSsaGraphBuilder extends ir.Visitor<void> with ir.VisitorVoidMixin {
     stack.add(_setListRuntimeTypeInfoIfNeeded(pop(), type, sourceInformation));
   }
 
-  /// Handle the legacy `List<T>()` constructor.
-  void _handleInvokeLegacyGrowableListFactoryConstructor(
-      ir.StaticInvocation invocation,
-      ConstructorEntity function,
-      AbstractValue typeMask,
-      List<HInstruction> arguments,
-      SourceInformation? sourceInformation) {
-    // `List<T>()` is essentially the same as `<T>[]`.
-    push(_buildLiteralList([]));
-    HInstruction allocation = pop();
-    var inferredType = globalInferenceResults.typeOfNewList(invocation);
-    if (inferredType != null) {
-      allocation.instructionType = inferredType;
-    }
-    InterfaceType type = _elementMap.createInterfaceType(
-        invocation.target.enclosingClass!, invocation.arguments.types);
-    stack.add(
-        _setListRuntimeTypeInfoIfNeeded(allocation, type, sourceInformation));
-  }
-
-  /// Handle the `JSArray<T>.list(length)` and legacy `List<T>(length)`
-  /// constructors.
-  void _handleInvokeLegacyFixedListFactoryConstructor(
-      ir.StaticInvocation invocation,
-      ConstructorEntity function,
-      AbstractValue typeMask,
-      List<HInstruction> arguments,
-      SourceInformation? sourceInformation) {
-    assert(
-        // Arguments may include the type.
-        arguments.length == 1 || arguments.length == 2,
-        failedAt(
-            function,
-            "Unexpected arguments. "
-            "Expected 1-2 argument, actual: $arguments."));
-    HInstruction lengthInput = arguments.first;
-    if (lengthInput.isNumber(_abstractValueDomain).isPotentiallyFalse) {
-      HPrimitiveCheck conversion = HPrimitiveCheck(
-          _commonElements.numType,
-          HPrimitiveCheck.ARGUMENT_TYPE_CHECK,
-          _abstractValueDomain.numType,
-          lengthInput,
-          sourceInformation);
-      add(conversion);
-      lengthInput = conversion;
-    }
-    js.Template code = js.js.parseForeignJS('new Array(#)');
-    var behavior = NativeBehavior();
-
-    DartType expectedType = _getStaticType(invocation).type;
-    behavior.typesInstantiated.add(expectedType);
-    behavior.typesReturned.add(expectedType);
-
-    // The allocation can throw only if the given length is a double or
-    // outside the unsigned 32 bit range.
-    // TODO(sra): Array allocation should be an instruction so that canThrow
-    // can depend on a length type discovered in optimization.
-    bool canThrow = true;
-    if (lengthInput.isUInt32(_abstractValueDomain).isDefinitelyTrue) {
-      canThrow = false;
-    }
-
-    var resultType = globalInferenceResults.typeOfNewList(invocation) ??
-        _abstractValueDomain.fixedListType;
-
-    HForeignCode foreign = HForeignCode(code, resultType, [lengthInput],
-        nativeBehavior: behavior,
-        throwBehavior:
-            canThrow ? NativeThrowBehavior.MAY : NativeThrowBehavior.NEVER)
-      ..sourceInformation = sourceInformation;
-    push(foreign);
-    js.Template fixedLengthMarker =
-        js.js.parseForeignJS(r'#.fixed$length = Array');
-    // We set the instruction as [canThrow] to avoid it being dead code.
-    // We need a finer grained side effect.
-    add(HForeignCode(
-        fixedLengthMarker, _abstractValueDomain.nullType, [stack.last],
-        throwBehavior: NativeThrowBehavior.MAY));
-
-    HInstruction newInstance = stack.last;
-
-    // If we inlined a constructor the call-site-specific type from type
-    // inference (e.g. a container type) will not be on the node. Store the
-    // more specialized type on the allocation.
-    newInstance.instructionType = resultType;
-    graph.allocatedFixedLists.add(newInstance);
-
-    InterfaceType type = _elementMap.createInterfaceType(
-        invocation.target.enclosingClass!, invocation.arguments.types);
-    stack.add(_setListRuntimeTypeInfoIfNeeded(pop(), type, sourceInformation));
-  }
-
   /// Replace calls to `extractTypeArguments` with equivalent code. Returns
   /// `true` if `extractTypeArguments` is handled.
   bool _handleExtractTypeArguments(

pkg/compiler/test/codegen/builtin_interceptor_test.dart

@@ -20,7 +20,7 @@ foo() {
 
 const String TEST_THREE = r"""
 foo() {
-  return List().add(2);
+  return [].add(2);
 }
 """;
 

pkg/compiler/test/codegen/gvn_test.dart

@@ -19,7 +19,7 @@ void foo(bar) {
 // GVN'ing the length of [:list:].
 const String TEST_TWO = r"""
 void foo(a) {
-  var list = List<int>();
+  var list = <int>[];
   list[0] = list[0 % a];
   list[1] = list[1 % a];
 }

pkg/compiler/test/codegen/list_tracer_length_test.dart

@@ -26,14 +26,14 @@ main() {
 }
 
 const String TEST3 = r"""
-var a = List(42);
+var a = List.filled(42, null);
 main() {
   return a[0];
 }
 """;
 
 const String TEST4 = r"""
-var a = List(0);
+var a = List.filled(0, null);
 main() {
   return a[0];
 }
@@ -75,15 +75,15 @@ main() {
 
 const String TEST8 = r"""
 var b = int.parse('42');
-var a = List(b);
+var a = List.filled(b, null);
 main() {
   return a[1];
 }
 """;
 
 const String TEST9 = r"""
 const b = 42;
-var a = List(b);
+var a = List.filled(b, null);
 main() {
   return a[1];
 }

pkg/compiler/test/codegen/list_tracer_node_type_test.dart

@@ -15,7 +15,7 @@ main() {
 
 const String TEST2 = r"""
 main() {
-  var a = List();
+  var a = [];
   a.add(42);
   a.add(null);
   return a[0] + 42;
@@ -24,7 +24,7 @@ main() {
 
 const String TEST3 = r"""
 main() {
-  var a = List(42);
+  var a = List<dynamic>.filled(42, null);
   a[a.length - 1] = 42;
   return a[0] + 42;
 }

pkg/compiler/test/codegen/value_range3_test.dart

@@ -16,7 +16,7 @@ var a = [42];
 main() {
   var value = a[0];
   if (value < 42) {
-    return List(42)[value];
+    return List.filled(42, null)[value];
   }
 }
 ''',