Version 1.20.0-dev.10.0

Merge commit '9bd4406d4ba9db9cda26089136d5cc16415125b0' into dev

Author: whesse

.travis.yml

@@ -35,10 +35,12 @@ before_install:
   - export PATH=`pwd`/depot_tools:"$PATH"
 
   # Checkout everything if we're building the SDK
-  - 'gclient config --spec=''solutions = [ { "name": ".", "url": "[email protected]:dart-lang/sdk.git", "deps_file": "DEPS", "managed": False, "custom_vars": { "dart_root": "." } } ]'''
-  - if [ "$CXX" ]; then gclient sync ; fi
+  - cd ..
+  - 'gclient config --spec=''solutions = [ { "name": "sdk", "url": "[email protected]:dart-lang/sdk.git", "deps_file": "DEPS", "managed": False } ]'''
+  - gclient sync
+  - cd sdk
 
-  # If a C++ compiler is set, built the SDK - else keep the preinstalled.
+  # If a C++ compiler is set, build the SDK - else use the preinstalled SDK instead.
   - if [ "$CXX" ]; then ./tools/build.py -m release create_sdk ; fi
   - if [ "$CXX" ]; then export PATH=`pwd`/out/ReleaseX64/dart-sdk/bin:"$PATH" ; fi
   - dart --version
@@ -49,6 +51,8 @@ before_install:
   - export CHROME_CANARY_BIN=`./tool/get_chrome_canary.sh`
   - export DISPLAY=:99.0
   - sh -e /etc/init.d/xvfb start
+install:
+  # Empty to suppress default pub get behavior
 before_script:
   # Node modules used by DDC
   - nvm install 5.5.0
@@ -69,7 +73,6 @@ matrix:
   allow_failures:
     - env: TEST=node
     - env: ANALYZER=master DDC_BROWSERS=Firefox
-    - env: ANALYZER=master CXX=clang++
     - env: ANALYZER=master CXX=g++
 notifications:
   email:

CHANGELOG.md

@@ -7,29 +7,32 @@
   [article on native extensions](https://www.dartlang.org/articles/dart-vm/native-extensions)
   to reflect the VM's improved behavior.
 
-* Linux builds of the VM will now use the tcmalloc library for memory
+* Linux builds of the VM will now use the `tcmalloc` library for memory
   allocation. This has the advantages of better debugging and profiling support
   and faster small allocations, with the cost of slightly larger initial memory
   footprint, and slightly slower large allocations.
 
 * We have improved the way the VM searches for trusted root certificates for
   secure socket connections on Linux. First, the VM will look for trusted root
   certificates in standard locations on the file system
-  (/etc/pki/tls/certs/ca-bundle.crt followed by /etc/ssl/certs), and only if
+  (`/etc/pki/tls/certs/ca-bundle.crt` followed by `/etc/ssl/certs`), and only if
   these do not exist will it fall back on the builtin trusted root certificates.
   This behavior can be overridden on Linux with the new flags
-  --root-certs-file and --root-certs-cache. The former is the path to a file
+  `--root-certs-file` and `--root-certs-cache`. The former is the path to a file
   containing the trusted root certificates, and the latter is the path to a
   directory containing root certificate files hashed using `c_rehash`.
 
+* The VM now throws a catchable `Error` when method compilation fails. This
+  allows easier debugging of syntax errors, especially when testing.
+
 ### Core library changes
 
 * `dart:core`: Remove deprecated `Resource` class.
   Use the class in `package:resource` instead.
 * `dart:async`
   * `Future.wait` now catches synchronous errors and returns them in the
     returned Future.
-  * More aggressively returns a Future on Stream.cancel operations.
+  * More aggressively returns a `Future` on `Stream.cancel` operations.
     Discourages to return `null` from `cancel`.
   * Fixes a few bugs where the cancel future wasn't passed through
     transformations.
@@ -115,6 +118,12 @@
     * Always split enum declarations if they end in a trailing comma.
     * Add `--set-exit-if-changed` to set the exit code on a change.
 
+* Pub
+  * Pub no longer generates a `packages/` directory by default.  Instead, it
+    generates a `.packages` file, called a package spec. To generate
+    a `packages/` directory in addition to the package spec, use the
+    `--packages-dir` flag with `pub get`, `pub upgrade`, and `pub downgrade`.
+
 ## 1.19.0
 
 ### Language changes

DEPS

@@ -31,7 +31,7 @@ vars = {
   "co19_rev": "@d4767b4caea3c5828ad8e053cd051d44a59061af",
 
   # Revisions of GN related dependencies.
-  "buildtools_revision": "@565d04e8741429fb1b4f26d102f2c6c3b849edeb",
+  "buildtools_revision": "@3d2e47bf14e4e67816a53e304dea422fa18f9180",
 
   "gperftools_revision": "@7822b5b0b9fa7e016e1f6b46ea86f26f4691a457",
 
@@ -44,7 +44,7 @@ vars = {
   "barback_tag" : "@0.15.2+9",
   "bazel_worker_tag": "@0.1.1",
   "boolean_selector_tag" : "@1.0.2",
-  "boringssl_gen_rev": "@1e8e5da213d0d5b1d50fcc1356c4783091bcc20d",
+  "boringssl_gen_rev": "@922830c0aad900dd3d143eef1ba06faa83fe263b",
   "boringssl_rev" : "@8d343b44bbab829d1a28fdef650ca95f7db4412e",
   "charcode_tag": "@1.1.0",
   "chrome_rev" : "@19997",
@@ -91,7 +91,7 @@ vars = {
   "pool_tag": "@1.2.4",
   "protobuf_tag": "@0.5.3",
   "pub_cache_tag": "@v0.1.0",
-  "pub_rev": "@4ef3e3e8ad8089733d617505cc66fa3d8049b4ae",
+  "pub_rev": "@3dd04bd17ba269ccdd34502a253041dd96ded3be",
   "pub_semver_tag": "@1.3.0",
   "quiver_tag": "@0.22.0",
   "resource_rev":"@a49101ba2deb29c728acba6fb86000a8f730f4b1",

build/config/android/config.gni

@@ -114,7 +114,7 @@ if (is_android) {
   arm_android_toolchain_root = "$android_ndk_root/toolchains/arm-linux-androideabi-${_android_toolchain_version}/prebuilt/${android_host_os}-${android_host_arch}"
   mips_android_toolchain_root = "$android_ndk_root/toolchains/mipsel-linux-android-${_android_toolchain_version}/prebuilt/${android_host_os}-${android_host_arch}"
   x86_64_android_toolchain_root = "$android_ndk_root/toolchains/x86_64-${_android_toolchain_version}/prebuilt/${android_host_os}-${android_host_arch}"
-  arm64_android_toolchain_root = "$android_ndk_root/toolchains/aarch64-${_android_toolchain_version}/prebuilt/${android_host_os}-${android_host_arch}"
+  arm64_android_toolchain_root = "$android_ndk_root/toolchains/aarch64-linux-android-${_android_toolchain_version}/prebuilt/${android_host_os}-${android_host_arch}"
   mips64_android_toolchain_root = "$android_ndk_root/toolchains/mips64el-${_android_toolchain_version}/prebuilt/${android_host_os}-${android_host_arch}"
 
   # Location of libgcc. This is only needed for the current GN toolchain, so we

build/config/compiler/BUILD.gn

@@ -53,6 +53,7 @@ if (!is_win) {
 # where stuff should go. Put warning related stuff in the "warnings" config.
 
 config("compiler") {
+  asmflags = []
   cflags = []
   cflags_c = []
   cflags_cc = []
@@ -447,6 +448,14 @@ config("compiler") {
       }
     }
   }
+
+  # Assign any flags set for the C compiler to asmflags so that they are sent
+  # to the assembler. The Windows assembler takes different types of flags
+  # so only do so for posix platforms.
+  if (is_posix) {
+    asmflags += cflags
+    asmflags += cflags_c
+  }
 }
 
 config("compiler_arm_fpu") {

build/toolchain/android/BUILD.gn

@@ -142,7 +142,7 @@ android_gcc_toolchains_helper("arm64") {
   android_ndk_sysroot = "$android_ndk_root/$arm64_android_sysroot_subdir"
   android_ndk_lib_dir = "usr/lib"
 
-  tool_prefix = "$arm64_android_toolchain_root/bin/arm-linux-androideabi-"
+  tool_prefix = "$arm64_android_toolchain_root/bin/aarch64-linux-android-"
   toolchain_cpu = "aarch64"
 }
 

build/toolchain/gcc_toolchain.gni

@@ -116,7 +116,7 @@ template("gcc_toolchain") {
     tool("asm") {
       # For GCC we can just use the C compiler to compile assembly.
       depfile = "{{output}}.d"
-      command = "$cc -MMD -MF $depfile {{defines}} {{include_dirs}} {{cflags}} {{cflags_c}} -c {{source}} -o {{output}}"
+      command = "$cc -MMD -MF $depfile {{defines}} {{include_dirs}} {{asmflags}} -c {{source}} -o {{output}}"
       depsformat = "gcc"
       description = "ASM {{output}}"
       outputs = [
@@ -232,7 +232,7 @@ template("gcc_toolchain") {
 
     # When invoking this toolchain not as the default one, these args will be
     # passed to the build. They are ignored when this is the default toolchain.
-    toolchain_args() {
+    toolchain_args = {
       current_cpu = invoker.toolchain_cpu
       current_os = invoker.toolchain_os
 

build/toolchain/mac/BUILD.gn

@@ -85,7 +85,7 @@ template("mac_toolchain") {
     tool("asm") {
       # For GCC we can just use the C compiler to compile assembly.
       depfile = "{{output}}.d"
-      command = "$cc -MMD -MF $depfile {{defines}} {{include_dirs}} $sysroot_flags $toolchain_flags {{cflags}} {{cflags_c}} -c {{source}} -o {{output}}"
+      command = "$cc -MMD -MF $depfile {{defines}} {{include_dirs}} $sysroot_flags $toolchain_flags {{asmflags}} -c {{source}} -o {{output}}"
       depsformat = "gcc"
       description = "ASM {{output}}"
       outputs = [
@@ -193,7 +193,7 @@ template("mac_toolchain") {
       description = "COPY {{source}} {{output}}"
     }
 
-    toolchain_args() {
+    toolchain_args = {
       current_cpu = invoker.toolchain_cpu
       current_os = invoker.toolchain_os
 

build/toolchain/win/BUILD.gn

@@ -121,7 +121,7 @@ template("msvc_toolchain") {
     tool("asm") {
       # TODO(brettw): "/safeseh" assembler argument is hardcoded here. Extract
       # assembler flags to a variable like cflags. crbug.com/418613
-      command = "$python_path gyp-win-tool asm-wrapper $env ml.exe {{defines}} {{include_dirs}} /safeseh /c /Fo {{output}} {{source}}"
+      command = "$python_path gyp-win-tool asm-wrapper $env ml.exe {{defines}} {{include_dirs}} {{asmflags}} /safeseh /c /Fo {{output}} {{source}}"
       description = "ASM {{output}}"
       outputs = [
         "{{target_out_dir}}/{{target_output_name}}/{{source_name_part}}.obj",

docs/language/dartLangSpec.tex

@@ -2083,10 +2083,9 @@ \subsection{Mixin Application}
 }
 
 \LMHash{}
-The effect of a class definition of the form \code{\CLASS{} $C$ = $M$; } or the form
- \code{\CLASS{} $C<T_1, \ldots, T_n>$ = $M$; } in library $L$  is to introduce the name $C$ into the scope of $L$, bound to the class (\ref{classes}) defined by the mixin application $M$. The name of the class is also set to $C$. Iff the  class is prefixed by the built-in identifier \ABSTRACT{}, the class being defined is an abstract class.
+The effect of a class definition of the form \code{\CLASS{} $C$ = $M$; } or the form \code{\CLASS{} $C<T_1, \ldots, T_n>$ = $M$; } in library $L$  is to introduce the name $C$ into the scope of $L$, bound to the class (\ref{classes}) defined by the mixin application $M$. The name of the class is also set to $C$. Iff the  class is prefixed by the built-in identifier \ABSTRACT{}, the class being defined is an abstract class.
 
- Let $M_A$ be a mixin derived from a class $M$ with direct superclass $S_{static}$.
+Let $M_A$ be a mixin derived from a class $M$ with direct superclass $S_{static}$, e.g., as defined by the class declaration \code{class M extends S$_{static}$ \{ \ldots \}}.
 
 Let $A$ be an application of $M_A$. It is a static warning if the superclass of $A$ is not a subtype of $S_{static}$.
 
@@ -2469,8 +2468,8 @@ \subsection{Constants}
 }
 
 \begin{dartCode}
-\CONST{} x = 1/0;
-\FINAL{} y = 1/0;
+\CONST{} x = 1 ~/ 0;
+\FINAL{} y = 1 ~/ 0;
 
 \CLASS{} K \{
   m1() \{
@@ -2590,7 +2589,7 @@ \subsection{Numbers}
  \end{grammar}
 
 \LMHash{}
-If a numeric literal begins with the prefix `0x' or `0X', it denotes the hexadecimal integer represented by the part of the literal following `0x' (respectively `0X'). Otherwise, if the numeric literal does not include a decimal point  it denotes a decimal integer.  Otherwise, the numeric literal  denotes a 64 bit double precision floating point number as specified by the IEEE 754 standard.
+If a numeric literal begins with the prefix `0x' or `0X', it denotes the hexadecimal integer represented by the part of the literal following `0x' (respectively `0X'). Otherwise, if the numeric literal contains only decimal digits, it denotes a decimal integer.  Otherwise, the numeric literal contains either a decimal point or an exponent part and it denotes a 64 bit double precision floating point number as specified by the IEEE 754 standard.
 
 \LMHash{}
 In principle, the range of integers supported by a Dart implementations is unlimited. In practice, it is limited by available memory. Implementations may also be limited by other considerations.
@@ -2872,7 +2871,7 @@ \subsection{Symbols}
 A symbol literal \code{\#id} where \code{id} does not begin with an underscore ('\code{\_}')  is equivalent to the expression \code{\CONST{} Symbol('id')}.
 
 \LMHash{}
-A symbol literal \code{\#\_id} evaluates to the object that would be returned by the call \code{mirror.getPrivateSymbol('id')} where mirror is an instance of the class \code{LibraryMirror} defined in the library \code{dart:mirrors}, reflecting the current library.
+A symbol literal \code{\#\_id} evaluates to the object that would be returned by the call \code{MirrorSystem.getSymbol("\_id", libraryMirror)} where \code{libraryMirror} is an instance of the class \code{LibraryMirror} defined in the library \code{dart:mirrors}, reflecting the current library.
 
 \rationale{
 One may well ask what is the motivation for introducing literal symbols? In some languages, symbols are canonicalized whereas strings are not. However literal strings are already canonicalized in Dart.  Symbols are slightly easier to type compared to strings and their use can become strangely addictive, but this is not nearly sufficient justification for adding a literal form to the language. The primary motivation is related to the use of reflection and a web specific practice known as minification.

pkg/analysis_server/lib/src/services/correction/fix.dart

@@ -165,8 +165,12 @@ class DartFixKind {
       'CREATE_NO_SUCH_METHOD', 51, "Create 'noSuchMethod' method");
   static const IMPORT_LIBRARY_PREFIX = const FixKind('IMPORT_LIBRARY_PREFIX',
       51, "Use imported library '{0}' with prefix '{1}'");
-  static const IMPORT_LIBRARY_PROJECT =
-      const FixKind('IMPORT_LIBRARY_PROJECT', 49, "Import library '{0}'");
+  static const IMPORT_LIBRARY_PROJECT1 =
+      const FixKind('IMPORT_LIBRARY_PROJECT1', 47, "Import library '{0}'");
+  static const IMPORT_LIBRARY_PROJECT2 =
+      const FixKind('IMPORT_LIBRARY_PROJECT2', 48, "Import library '{0}'");
+  static const IMPORT_LIBRARY_PROJECT3 =
+      const FixKind('IMPORT_LIBRARY_PROJECT3', 49, "Import library '{0}'");
   static const IMPORT_LIBRARY_SDK =
       const FixKind('IMPORT_LIBRARY_SDK', 49, "Import library '{0}'");
   static const IMPORT_LIBRARY_SHOW =

pkg/analysis_server/lib/src/services/correction/fix_internal.dart

@@ -1554,8 +1554,22 @@ class FixProcessor {
         if (element.kind != kind) {
           continue;
         }
-        _addFix_importLibrary(
-            DartFixKind.IMPORT_LIBRARY_PROJECT, libraryElement);
+        // Compute the fix kind.
+        FixKind fixKind;
+        if (resourceProvider.pathContext
+            .split(librarySource.fullName)
+            .contains('src')) {
+          // Bad: non-API.
+          fixKind = DartFixKind.IMPORT_LIBRARY_PROJECT3;
+        } else if (element.library != libraryElement) {
+          // Ugly: exports.
+          fixKind = DartFixKind.IMPORT_LIBRARY_PROJECT2;
+        } else {
+          // Good: direct declaration.
+          fixKind = DartFixKind.IMPORT_LIBRARY_PROJECT1;
+        }
+        // Add the fix.
+        _addFix_importLibrary(fixKind, libraryElement);
       }
     }
   }