Store the actual static type of IntegerLiteral(s) in summary.

Fixes #35993
Fixes #33441

Change-Id: I369da4e4437db5ae31fb1c4eb7d3ab0657d9ceb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120520
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Paul Berry <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/constant/evaluation.dart

@@ -862,19 +862,6 @@ class ConstantEvaluationEngine {
       return true;
     }
     var objType = obj.type;
-    if (objType.isDartCoreInt && type.isDartCoreDouble) {
-      // Work around dartbug.com/35993 by allowing `int` to be used in a place
-      // where `double` is expected.
-      //
-      // Note that this is not technically correct, because it allows code like
-      // this:
-      //   const Object x = 1;
-      //   const double y = x;
-      //
-      // TODO(paulberry): remove this workaround once dartbug.com/33441 is
-      // fixed.
-      return true;
-    }
     return typeSystem.isSubtypeOf(objType, type);
   }
 

pkg/analyzer/test/src/diagnostics/variable_type_mismatch_test.dart

@@ -17,7 +17,6 @@ main() {
 /// to this class.
 @reflectiveTest
 class VariableTypeMismatchTest extends DriverResolutionTest {
-  @FailingTest(reason: 'Workaround for #35993 is too broad')
   test_int_to_double_variable_reference_is_not_promoted() async {
     // Note: in the following code, the declaration of `y` should produce an
     // error because we should only promote literal ints to doubles; we