[web] remove top-level scripts for dartdevc and dart2js.

This completes the breaking change that was previously announced in
#46100

Change-Id: Ie81665e7932fe00a8c1fee9f67ee8294cd4c89e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248342
Reviewed-by: Joshua Litt <[email protected]>
Commit-Queue: Sigmund Cherem <[email protected]>
Reviewed-by: Nicholas Shahan <[email protected]>

Author: sigmundch

CHANGELOG.md

@@ -140,6 +140,13 @@ them, you must set the lower bound on the SDK constraint for your package to
 
 ### Tools
 
+#### Dart command line
+
+- **Breaking change** [#46100](https://github.com/dart-lang/sdk/issues/46100):
+  The standalone `dart2js` and `dartdevc` tools have been removed as previously
+  announced. `dart2js` is replaced by the `dart compile js` command, `dartdevc`
+  is no longer exposed as a command-line tool.
+
 #### Linter
 
 Updated the Linter to `1.25.0`, which includes changes that

pkg/dev_compiler/tool/ddb

@@ -174,7 +174,7 @@ void main(List<String> args) async {
         mode: ProcessStartMode.inheritStdio, environment: environment);
   }
 
-  Future<void> runDdc(String command, List<String> args) async {
+  Future<void> runDdc(List<String> args) async {
     if (debug) {
       // Use unbuilt script.  This only works from a source checkout.
       var vmServicePort = options.wasParsed('vm-service-port')
@@ -188,14 +188,14 @@ void main(List<String> args) async {
           '--pause-isolates-on-start',
         ],
         '--enable-asserts',
-        p.join(ddcPath, 'bin', '$command.dart')
+        p.join(ddcPath, 'bin', 'dartdevc.dart')
       ]);
-      command = dartBinary;
     } else {
       // Use built snapshot.
-      command = p.join(dartSdk, 'bin', command);
+      args.insertAll(
+          0, [p.join(dartSdk, 'bin', 'snapshots', 'dartdevc.dart.snapshot')]);
     }
-    var process = await startProcess('DDC', command, args, <String, String>{
+    var process = await startProcess('DDC', dartBinary, args, <String, String>{
       if (options['compile-vm-options'] != null)
         'DART_VM_OPTIONS': options['compile-vm-options'] as String
     });
@@ -249,7 +249,7 @@ void main(List<String> args) async {
       out,
       entry
     ];
-    await runDdc('dartdevc', ddcArgs);
+    await runDdc(ddcArgs);
   }
 
   if (run) {

sdk/BUILD.gn

@@ -90,11 +90,7 @@ declare_args() {
 # Scripts that go under bin/
 _platform_sdk_scripts = [ "dartanalyzer" ]
 
-_full_sdk_scripts = [
-  "dart2js",
-  "dartanalyzer",
-  "dartdevc",
-]
+_full_sdk_scripts = [ "dartanalyzer" ]
 
 # Snapshots that go under bin/snapshots
 _platform_sdk_snapshots = [