Skip to content

Commit 6bcb186

Browse files
nshahanCommit Bot
authored and
Commit Bot
committed
[ddc] Add new test and builder configurations
- Add new versions of exisiting configurations to support the arm64 architecture. The current DDC configurations don't name one but default to x64. In the future I would like to remove the default and simply specify (x64|arm64) but I'm not making this change now because I don't want to break the history in the test database. - Add new "canary" named test configurations that rely on a specific builder to pass a build time flag `--gn-args ddc_canary=true`. Change-Id: I675899ea2e952e2183b8379b60ddaa67e8b864a5 Issue: #48950 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243562 Reviewed-by: Alexander Thomas <[email protected]> Commit-Queue: Nicholas Shahan <[email protected]>
1 parent 2577bef commit 6bcb186

File tree

2 files changed

+108
-0
lines changed

2 files changed

+108
-0
lines changed

pkg/test_runner/lib/src/compiler_configuration.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -602,6 +602,7 @@ class DevCompilerConfiguration extends CompilerConfiguration {
602602
..._experimentsArgument(_configuration, testFile),
603603
...testFile.ddcOptions,
604604
if (_configuration.nnbdMode == NnbdMode.strong) '--sound-null-safety',
605+
if (_configuration.configuration.builderTag == 'canary') '--canary',
605606
// The file being compiled is the last argument.
606607
args.last
607608
];

tools/bots/test_matrix.json

Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -916,6 +916,42 @@
916916
"enable-asserts": true
917917
}
918918
},
919+
"dartdevc-checked-(linux|mac|win)-(debug|product|release)-(chrome|firefox)-arm64": {
920+
"options": {
921+
"checked": true,
922+
"use-sdk": true
923+
}
924+
},
925+
"dartdevc-strong-linux-release-chrome-arm64": {
926+
"options": {
927+
"checked": true,
928+
"use-sdk": true,
929+
"enable-asserts": true
930+
}
931+
},
932+
"dartdevc-weak-linux-release-chrome-arm64": {
933+
"options": {
934+
"checked": true,
935+
"use-sdk": true,
936+
"enable-asserts": true
937+
}
938+
},
939+
"dartdevc-canary-strong-(linux|mac|win)-release-(chrome|firefox)-(x64|arm64)": {
940+
"options": {
941+
"builder-tag": "canary",
942+
"checked": true,
943+
"use-sdk": true,
944+
"enable-asserts": true
945+
}
946+
},
947+
"dartdevc-canary-weak-(linux|mac|win)-release-(chrome|firefox)-(x64|arm64)": {
948+
"options": {
949+
"builder-tag": "canary",
950+
"checked": true,
951+
"use-sdk": true,
952+
"enable-asserts": true
953+
}
954+
},
919955
"cfe-(linux|mac|win)": {
920956
"options": {
921957
"compiler": "fasta"
@@ -2358,6 +2394,77 @@
23582394
}
23592395
]
23602396
},
2397+
{
2398+
"builders": [
2399+
"ddc-canary-linux-release-chrome"
2400+
],
2401+
"meta": {
2402+
"description": "This configuration is used by the ddc canary builder group."
2403+
},
2404+
"steps": [
2405+
{
2406+
"name": "build dart",
2407+
"script": "tools/build.py",
2408+
"arguments": [
2409+
"dartdevc_test",
2410+
"--gn-args=ddc_canary=true"
2411+
]
2412+
},
2413+
{
2414+
"name": "ddc nnbd weak tests",
2415+
"arguments": [
2416+
"-ndartdevc-canary-weak-linux-release-chrome-x64",
2417+
"language",
2418+
"corelib",
2419+
"lib",
2420+
"dartdevc",
2421+
"web"
2422+
],
2423+
"shards": 2,
2424+
"fileset": "web_platform_nnbd"
2425+
},
2426+
{
2427+
"name": "ddc nnbd weak co19 tests",
2428+
"arguments": [
2429+
"-ndartdevc-canary-weak-linux-release-chrome-x64",
2430+
"co19"
2431+
],
2432+
"shards": 2,
2433+
"fileset": "web_platform_nnbd"
2434+
},
2435+
{
2436+
"name": "ddc nnbd strong co19 tests",
2437+
"arguments": [
2438+
"-ndartdevc-canary-strong-linux-release-chrome-x64",
2439+
"co19"
2440+
],
2441+
"shards": 3,
2442+
"fileset": "web_platform_nnbd"
2443+
},
2444+
{
2445+
"name": "ddc weak modular tests",
2446+
"script": "out/ReleaseX64/dart-sdk/bin/dart",
2447+
"testRunner": true,
2448+
"arguments": [
2449+
"pkg/dev_compiler/test/modular_suite_nnbd.dart",
2450+
"-ndartdevc-canary-weak-linux-release-chrome-x64",
2451+
"--verbose",
2452+
"--use-sdk"
2453+
]
2454+
},
2455+
{
2456+
"name": "ddc nnbd strong tests",
2457+
"arguments": [
2458+
"-ndartdevc-canary-strong-linux-release-chrome-x64",
2459+
"language",
2460+
"corelib",
2461+
"lib",
2462+
"dartdevc",
2463+
"web"
2464+
]
2465+
}
2466+
]
2467+
},
23612468
{
23622469
"builders": [
23632470
"ddc-mac-release-chrome"

0 commit comments

Comments
 (0)