analysis-server: fixed benchmark uploader for Windows benchmarks

Change-Id: Iae46a7f6f755c8e0d217c2f7f18d84551c18193c
Cq-Include-Trybots: luci.dart.try:analyzer-win-release-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/548200
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Sinan Oz <sinanoz@google.com>

Author: sinanoz-google

DEPS

@@ -79,6 +79,9 @@ vars = {
   "jsshell_tag": "version:155.0.1",
   "jsc_tag": "version:320707",
 
+  # https://chrome-infra-packages.appspot.com/p/infra/3pp/tools/gcloud
+  "gcloud_version": "version:3@584.0.0.chromium.4",
+
   # https://chrome-infra-packages.appspot.com/p/fuchsia/third_party/clang
   "clang_version": "git_revision:5e63f2ce42db2c42f1d0012a3b5fa9c6113f750a",
 
@@ -297,6 +300,14 @@ deps = {
       "dep_type": "cipd",
   },
 
+  Var("dart_root") + "/third_party/gcloud": {
+      "packages": [{
+          "package": "infra/3pp/tools/gcloud/${{platform}}",
+          "version": Var("gcloud_version"),
+      }],
+      "dep_type": "cipd"
+  },
+
   Var("dart_root") + "/third_party/emsdk":
       Var("dart_git") + "external/github.com/emscripten-core/emsdk.git" +
       "@" + Var("emsdk_rev"),

pkg/analysis_server/benchmark/perf/benchmark_uploader.dart

@@ -109,10 +109,18 @@ Future<void> uploadResults(List<Map<String, dynamic>> results) async {
     }
     var cloudStoragePath =
         'gs://dart-test-results/benchmarks/$taskId/results.json';
-    var args = ['gcloud', 'storage', 'cp', resultsFile.path, cloudStoragePath];
-    var python = 'python3.exe';
-    print('Running $python ${args.join(' ')}');
-    var commandResult = await Process.run(python, args);
+    var args = ['storage', 'cp', resultsFile.path, cloudStoragePath];
+    var gcloudSuffix = Platform.isWindows ? '.cmd' : '';
+    var gcloud = Platform.script
+        .resolve('../../../../third_party/gcloud/bin/gcloud$gcloudSuffix')
+        .toFilePath();
+
+    print('Running $gcloud ${args.join(' ')}');
+    var commandResult = await Process.run(
+      gcloud,
+      args,
+      runInShell: Platform.isWindows,
+    );
     var exitCode = commandResult.exitCode;
     print(commandResult.stdout);
     print(commandResult.stderr);