[beta] Issue 52160. Report BASE_CLASS_IMPLEMENTED_OUTSIDE_OF_LIBRARY for implementing 'base' via 'extends'.

Bug: #52160
Change-Id: I47a72021a002663d04fd8ea14c11a012917e8a8c
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/298320
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/298201
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/error/base_or_final_type_verifier.dart

@@ -198,11 +198,15 @@ class BaseOrFinalTypeVerifier {
           superElement.isSealed &&
           baseOrFinalSuperElement.library != element.library) {
         if (baseOrFinalSuperElement.isBase) {
+          var errorCode = baseOrFinalSuperElement is MixinElement
+              ? CompileTimeErrorCode.BASE_MIXIN_IMPLEMENTED_OUTSIDE_OF_LIBRARY
+              : CompileTimeErrorCode.BASE_CLASS_IMPLEMENTED_OUTSIDE_OF_LIBRARY;
           _errorReporter.reportErrorForNode(
-              CompileTimeErrorCode.BASE_CLASS_IMPLEMENTED_OUTSIDE_OF_LIBRARY,
-              implementsNamedType,
-              [baseOrFinalSuperElement.displayName],
-              contextMessage);
+            errorCode,
+            implementsNamedType,
+            [baseOrFinalSuperElement.displayName],
+            contextMessage,
+          );
           return true;
         }
       }

pkg/analyzer/lib/src/generated/error_verifier.dart

@@ -1748,24 +1748,32 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
     for (NamedType interface in implementsClause.interfaces) {
       final interfaceType = interface.type;
       if (interfaceType is InterfaceType) {
-        final interfaceElement = interfaceType.element;
-        if (interfaceElement is ClassOrMixinElementImpl &&
-            interfaceElement.isBase &&
-            interfaceElement.library != _currentLibrary &&
-            !_mayIgnoreClassModifiers(interfaceElement.library)) {
-          // Should this be combined with _checkForImplementsClauseErrorCodes
-          // to avoid double errors if implementing `int`.
-          if (interfaceElement is ClassElementImpl &&
-              !interfaceElement.isSealed) {
-            errorReporter.reportErrorForNode(
-                CompileTimeErrorCode.BASE_CLASS_IMPLEMENTED_OUTSIDE_OF_LIBRARY,
-                interface,
-                [interfaceElement.name]);
-          } else if (interfaceElement is MixinElement) {
-            errorReporter.reportErrorForNode(
-                CompileTimeErrorCode.BASE_MIXIN_IMPLEMENTED_OUTSIDE_OF_LIBRARY,
-                interface,
-                [interfaceElement.name]);
+        final implementedInterfaces = [
+          interfaceType,
+          ...interfaceType.element.allSupertypes,
+        ].map((e) => e.element).toList();
+        for (final interfaceElement in implementedInterfaces) {
+          if (interfaceElement is ClassOrMixinElementImpl &&
+              interfaceElement.isBase &&
+              interfaceElement.library != _currentLibrary &&
+              !_mayIgnoreClassModifiers(interfaceElement.library)) {
+            // Should this be combined with _checkForImplementsClauseErrorCodes
+            // to avoid double errors if implementing `int`.
+            if (interfaceElement is ClassElementImpl &&
+                !interfaceElement.isSealed) {
+              errorReporter.reportErrorForNode(
+                  CompileTimeErrorCode
+                      .BASE_CLASS_IMPLEMENTED_OUTSIDE_OF_LIBRARY,
+                  interface,
+                  [interfaceElement.name]);
+            } else if (interfaceElement is MixinElement) {
+              errorReporter.reportErrorForNode(
+                  CompileTimeErrorCode
+                      .BASE_MIXIN_IMPLEMENTED_OUTSIDE_OF_LIBRARY,
+                  interface,
+                  [interfaceElement.name]);
+            }
+            break;
           }
         }
       }

pkg/analyzer/test/src/diagnostics/base_class_implemented_outside_of_library_test.dart

@@ -90,6 +90,21 @@ class C implements B {}
     ]);
   }
 
+  test_class_outside_viaExtends() async {
+    newFile('$testPackageLibPath/a.dart', r'''
+base class A {}
+''');
+
+    await assertErrorsInCode(r'''
+import 'a.dart';
+base class B extends A {}
+base class C implements B {}
+''', [
+      error(CompileTimeErrorCode.BASE_CLASS_IMPLEMENTED_OUTSIDE_OF_LIBRARY, 67,
+          1),
+    ]);
+  }
+
   test_class_outside_viaTypedef_inside() async {
     newFile('$testPackageLibPath/foo.dart', r'''
 base class Foo {}

pkg/analyzer/test/src/diagnostics/base_mixin_implemented_outside_of_library_test.dart

@@ -37,6 +37,23 @@ base class Bar implements Foo {}
     ]);
   }
 
+  test_class_outside_viaExtends() async {
+    newFile('$testPackageLibPath/a.dart', r'''
+base mixin A {}
+''');
+
+    await assertErrorsInCode(r'''
+import 'a.dart';
+
+sealed class B extends Object with A {}
+class C implements B {}
+''', [
+      error(
+          CompileTimeErrorCode.BASE_MIXIN_IMPLEMENTED_OUTSIDE_OF_LIBRARY, 77, 1,
+          contextMessages: [message('/home/test/lib/a.dart', 11, 1)]),
+    ]);
+  }
+
   test_class_outside_viaTypedef_inside() async {
     newFile('$testPackageLibPath/foo.dart', r'''
 base mixin Foo {}

pkg/analyzer/test/src/diagnostics/subtype_of_struct_class_test.dart

@@ -58,6 +58,8 @@ final class AbiSpecificInteger4 implements AbiSpecificInteger1 {
   const AbiSpecificInteger4();
 }
 ''', [
+      error(CompileTimeErrorCode.BASE_CLASS_IMPLEMENTED_OUTSIDE_OF_LIBRARY, 216,
+          19),
       error(FfiCode.SUBTYPE_OF_STRUCT_CLASS_IN_IMPLEMENTS, 216, 19),
     ]);
   }
@@ -69,8 +71,9 @@ final class S extends Struct {}
 final class C implements S {}
 ''', [
       error(FfiCode.EMPTY_STRUCT, 31, 1),
-      error(FfiCode.SUBTYPE_OF_STRUCT_CLASS_IN_IMPLEMENTS, 76, 1,
-          messageContains: ["class 'C'", "implement 'S'"]),
+      error(CompileTimeErrorCode.BASE_CLASS_IMPLEMENTED_OUTSIDE_OF_LIBRARY, 76,
+          1),
+      error(FfiCode.SUBTYPE_OF_STRUCT_CLASS_IN_IMPLEMENTS, 76, 1),
     ]);
   }
 
@@ -83,6 +86,8 @@ final class S extends Struct {}
 import 'lib1.dart' as lib1;
 class C implements lib1.S {}
 ''', [
+      error(CompileTimeErrorCode.BASE_CLASS_IMPLEMENTED_OUTSIDE_OF_LIBRARY, 47,
+          6),
       error(CompileTimeErrorCode.FINAL_CLASS_IMPLEMENTED_OUTSIDE_OF_LIBRARY, 47,
           6),
       error(FfiCode.SUBTYPE_OF_STRUCT_CLASS_IN_IMPLEMENTS, 47, 6),
@@ -96,6 +101,8 @@ final class S extends Union {}
 final class C implements S {}
 ''', [
       error(FfiCode.EMPTY_STRUCT, 31, 1),
+      error(CompileTimeErrorCode.BASE_CLASS_IMPLEMENTED_OUTSIDE_OF_LIBRARY, 75,
+          1),
       error(FfiCode.SUBTYPE_OF_STRUCT_CLASS_IN_IMPLEMENTS, 75, 1),
     ]);
   }