[ddc] Fix check for required named args in new type system

nshahan · Commit Queue · commit 8515c4a428dd · 2023-07-06T22:39:13.000Z
Issue: #48585 Change-Id: I119c0d649461ddfd3879f75ef232ee8010ebf787 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/312203 Commit-Queue: Nicholas Shahan <nshahan@google.com> Reviewed-by: Mark Zhou <markzipan@google.com>
diff --git a/sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart b/sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart
@@ -251,8 +251,8 @@ String? _argumentErrors(Object type, @notNull List actuals, namedActuals) {
       }
     }
     // Verify that all required named parameters are provided an argument.
-    if (requiredCount > 0) {
-      Iterable requiredNames = getOwnPropertyNames(requiredNamed);
+    Iterable requiredNames = getOwnPropertyNames(requiredNamed);
+    if (JS<int>('!', '#.length', requiredNames) > 0) {
       var missingRequired = namedActuals == null
           ? requiredNames
           : requiredNames.where((name) =>

Original file line number	Diff line number	Diff line change
`@@ -251,8 +251,8 @@ String? _argumentErrors(Object type, @notNull List actuals, namedActuals) {`
`251`	`251`	`}`
`252`	`252`	`}`
`253`	`253`	`// Verify that all required named parameters are provided an argument.`
`254`		`- if (requiredCount > 0) {`
`255`		`- Iterable requiredNames = getOwnPropertyNames(requiredNamed);`
	`254`	`+ Iterable requiredNames = getOwnPropertyNames(requiredNamed);`
	`255`	`+ if (JS<int>('!', '#.length', requiredNames) > 0) {`
`256`	`256`	`var missingRequired = namedActuals == null`
`257`	`257`	`? requiredNames`
`258`	`258`	`: requiredNames.where((name) =>`