Skip to content

Commit 8bf424e

Browse files
alexmarkovcommit-bot@chromium.org
authored andcommitted
Revert "[vm/bytecode] Enable bytecode compiler by default in Dart SDK"
This reverts commit 31996aa. Reason for revert: bytecode mode is disabled to avoid gaps in testing of AST-based mode. Original change's description: > [vm/bytecode] Enable bytecode compiler by default in Dart SDK > > This is the reland of https://dart-review.googlesource.com/c/sdk/+/110551. > > Change-Id: I85fcfadfd20fdba752fa8225650a1cb6c32fff31 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117931 > Reviewed-by: Régis Crelier <[email protected]> > Commit-Queue: Alexander Markov <[email protected]> [email protected],[email protected],[email protected],[email protected] # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I941eff705b599c59251e5ba2337c307cc84f373b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120720 Reviewed-by: Alexander Markov <[email protected]> Reviewed-by: Ryan Macnak <[email protected]> Reviewed-by: Régis Crelier <[email protected]> Commit-Queue: Alexander Markov <[email protected]>
1 parent ee42196 commit 8bf424e

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

runtime/runtime_args.gni

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ declare_args() {
8080
dart_component_kind = "static_library"
8181
}
8282

83-
# Controls whether the VM uses bytecode.
84-
dart_platform_bytecode = true
83+
# Whether the VM's platform dill file contains bytecode.
84+
dart_platform_bytecode = false
8585

8686
# Whether the VM includes the kernel service in all modes (debug, release,
8787
# product).

tools/gn.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -428,14 +428,9 @@ def parse_args(args):
428428
other_group.add_argument(
429429
'--bytecode',
430430
'-b',
431-
help='Use bytecode in Dart VM',
432-
default=True,
431+
help='Include bytecode in the VMs platform dill',
432+
default=False,
433433
action="store_true")
434-
other_group.add_argument(
435-
'--no-bytecode',
436-
help='Disable bytecode in Dart VM',
437-
dest='bytecode',
438-
action="store_false")
439434
other_group.add_argument(
440435
'--clang', help='Use Clang', default=True, action='store_true')
441436
other_group.add_argument(

0 commit comments

Comments
 (0)