Skip to content

Commit 8d65076

Browse files
mit-mitcommit-bot@chromium.org
authored andcommitted
Change terms to be more divisive
Based on guidance in https://developers.google.com/style/ Related to #42247 Change-Id: Ia4edb2cb0540781f1119c369406a7b65553e26f6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150632 Reviewed-by: Siva Annamalai <[email protected]> Commit-Queue: Michael Thomsen <[email protected]>
1 parent 5b51895 commit 8d65076

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

tests/language_2/unsorted/black_listed_test.dart renamed to tests/language_2/unsorted/deny_listed_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// BSD-style license that can be found in the LICENSE file.
44
// Dart test checking that static/instance field shadowing do not conflict.
55

6-
// Test that certain interfaces/classes are blacklisted from being
6+
// Test that certain interfaces/classes are denylisted from being
77
// implemented or extended.
88

99
// bool.

tests/lib/mirrors/invocation_fuzz_test.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import 'dart:async';
1414
import 'dart:io';
1515

1616
// Methods to be skipped, by qualified name.
17-
var blacklist = [
17+
var denylist = [
1818
// Don't recurse on this test.
1919
'test.invoke_natives',
2020

@@ -39,9 +39,9 @@ var blacklist = [
3939
new RegExp(r"^dart\.async\._.*$"),
4040
];
4141

42-
bool isBlacklisted(Symbol qualifiedSymbol) {
42+
bool isDenylisted(Symbol qualifiedSymbol) {
4343
var qualifiedString = MirrorSystem.getName(qualifiedSymbol);
44-
for (var pattern in blacklist) {
44+
for (var pattern in denylist) {
4545
if (qualifiedString.contains(pattern)) {
4646
print('Skipping $qualifiedString');
4747
return true;
@@ -58,7 +58,7 @@ class Task {
5858
var queue = <Task>[];
5959

6060
checkMethod(MethodMirror m, ObjectMirror target, [origin]) {
61-
if (isBlacklisted(m.qualifiedName)) return;
61+
if (isDenylisted(m.qualifiedName)) return;
6262

6363
var task = new Task();
6464
task.name = '${MirrorSystem.getName(m.qualifiedName)} from $origin';
@@ -97,7 +97,7 @@ checkClass(classMirror) {
9797
classMirror.declarations.values
9898
.where((d) => d is MethodMirror && d.isConstructor)
9999
.forEach((m) {
100-
if (isBlacklisted(m.qualifiedName)) return;
100+
if (isDenylisted(m.qualifiedName)) return;
101101
var task = new Task();
102102
task.name = MirrorSystem.getName(m.qualifiedName);
103103

@@ -112,7 +112,7 @@ checkClass(classMirror) {
112112

113113
checkLibrary(libraryMirror) {
114114
print(libraryMirror.simpleName);
115-
if (isBlacklisted(libraryMirror.qualifiedName)) return;
115+
if (isDenylisted(libraryMirror.qualifiedName)) return;
116116

117117
libraryMirror.declarations.values
118118
.where((d) => d is ClassMirror)

tests/lib_2/mirrors/invocation_fuzz_test.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import 'dart:async';
1414
import 'dart:io';
1515

1616
// Methods to be skipped, by qualified name.
17-
var blacklist = [
17+
var denylist = [
1818
// Don't recurse on this test.
1919
'test.invoke_natives',
2020

@@ -39,9 +39,9 @@ var blacklist = [
3939
new RegExp(r"^dart\.async\._.*$"),
4040
];
4141

42-
bool isBlacklisted(Symbol qualifiedSymbol) {
42+
bool isDenylisted(Symbol qualifiedSymbol) {
4343
var qualifiedString = MirrorSystem.getName(qualifiedSymbol);
44-
for (var pattern in blacklist) {
44+
for (var pattern in denylist) {
4545
if (qualifiedString.contains(pattern)) {
4646
print('Skipping $qualifiedString');
4747
return true;
@@ -58,7 +58,7 @@ class Task {
5858
var queue = new List<Task>();
5959

6060
checkMethod(MethodMirror m, ObjectMirror target, [origin]) {
61-
if (isBlacklisted(m.qualifiedName)) return;
61+
if (isDenylisted(m.qualifiedName)) return;
6262

6363
var task = new Task();
6464
task.name = '${MirrorSystem.getName(m.qualifiedName)} from $origin';
@@ -97,7 +97,7 @@ checkClass(classMirror) {
9797
classMirror.declarations.values
9898
.where((d) => d is MethodMirror && d.isConstructor)
9999
.forEach((m) {
100-
if (isBlacklisted(m.qualifiedName)) return;
100+
if (isDenylisted(m.qualifiedName)) return;
101101
var task = new Task();
102102
task.name = MirrorSystem.getName(m.qualifiedName);
103103

@@ -112,7 +112,7 @@ checkClass(classMirror) {
112112

113113
checkLibrary(libraryMirror) {
114114
print(libraryMirror.simpleName);
115-
if (isBlacklisted(libraryMirror.qualifiedName)) return;
115+
if (isDenylisted(libraryMirror.qualifiedName)) return;
116116

117117
libraryMirror.declarations.values
118118
.where((d) => d is ClassMirror)

tests/standalone_2/black_listed_test.dart renamed to tests/standalone_2/deny_listed_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// BSD-style license that can be found in the LICENSE file.
44
// Dart test checking that static/instance field shadowing do not conflict.
55

6-
// Test that certain interfaces/classes are blacklisted from being
6+
// Test that certain interfaces/classes are denylisted from being
77
// implemented or extended (VM corelib only).
88

99
library BlackListedTest;

0 commit comments

Comments
 (0)