[vm] Initial implementation of dynamic modules in the VM/AOT

TEST=Manually tested dynamic modules

Change-Id: Icb2616e414167bd1fbd10f01dea64c57dbdeeac7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380281
Reviewed-by: Slava Egorov <[email protected]>
Commit-Queue: Alexander Markov <[email protected]>

Author: alexmarkov

runtime/BUILD.gn

@@ -172,6 +172,10 @@ config("dart_config") {
     defines += [ "SUPPORT_PERFETTO" ]
   }
 
+  if (dart_dynamic_modules) {
+    defines += [ "DART_DYNAMIC_MODULES" ]
+  }
+
   if (is_fuchsia) {
     lib_dirs = [ "${fuchsia_arch_root}/lib" ]
 

runtime/lib/errors.cc

@@ -31,21 +31,25 @@ static ScriptPtr FindScript(DartFrameIterator* iterator) {
   ASSERT(!assert_error_class.IsNull());
   bool hit_assertion_error = false;
   for (; stack_frame != nullptr; stack_frame = iterator->NextFrame()) {
-    code = stack_frame->LookupDartCode();
-    if (code.is_optimized()) {
-      InlinedFunctionsIterator inlined_iterator(code, stack_frame->pc());
-      while (!inlined_iterator.Done()) {
-        func = inlined_iterator.function();
-        if (hit_assertion_error) {
-          return func.script();
+    if (stack_frame->is_interpreted()) {
+      func = stack_frame->LookupDartFunction();
+    } else {
+      code = stack_frame->LookupDartCode();
+      if (code.is_optimized()) {
+        InlinedFunctionsIterator inlined_iterator(code, stack_frame->pc());
+        while (!inlined_iterator.Done()) {
+          func = inlined_iterator.function();
+          if (hit_assertion_error) {
+            return func.script();
+          }
+          ASSERT(!hit_assertion_error);
+          hit_assertion_error = (func.Owner() == assert_error_class.ptr());
+          inlined_iterator.Advance();
         }
-        ASSERT(!hit_assertion_error);
-        hit_assertion_error = (func.Owner() == assert_error_class.ptr());
-        inlined_iterator.Advance();
+        continue;
+      } else {
+        func = code.function();
       }
-      continue;
-    } else {
-      func = code.function();
     }
     ASSERT(!func.IsNull());
     if (hit_assertion_error) {

runtime/lib/object.cc

@@ -5,6 +5,7 @@
 #include "vm/bootstrap_natives.h"
 
 #include "lib/invocation_mirror.h"
+#include "vm/bytecode_reader.h"
 #include "vm/code_patcher.h"
 #include "vm/dart_entry.h"
 #include "vm/exceptions.h"
@@ -560,6 +561,61 @@ DEFINE_NATIVE_ENTRY(Internal_boundsCheckForPartialInstantiation, 0, 2) {
   return Object::null();
 }
 
+DEFINE_NATIVE_ENTRY(Internal_loadDynamicModule, 0, 1) {
+#if defined(DART_DYNAMIC_MODULES)
+  GET_NON_NULL_NATIVE_ARGUMENT(TypedData, module_bytes,
+                               arguments->NativeArgAt(0));
+
+  const intptr_t length = module_bytes.LengthInBytes();
+  uint8_t* data = reinterpret_cast<uint8_t*>(::malloc(length));
+  if (data == nullptr) {
+    const auto& exception = Instance::Handle(
+        zone, thread->isolate_group()->object_store()->out_of_memory());
+    Exceptions::Throw(thread, exception);
+  }
+  {
+    NoSafepointScope no_safepoint;
+    // The memory does not overlap.
+    memcpy(data, module_bytes.DataAddr(0), length);  // NOLINT
+  }
+  const ExternalTypedData& typed_data = ExternalTypedData::Handle(
+      zone,
+      ExternalTypedData::New(kExternalTypedDataUint8ArrayCid, data, length));
+  auto& function = Function::Handle();
+  {
+    SafepointWriteRwLocker ml(thread, thread->isolate_group()->program_lock());
+    bytecode::BytecodeLoader loader(thread, typed_data);
+    function = loader.LoadBytecode();
+  }
+
+  if (function.IsNull()) {
+    return Object::null();
+  }
+  ASSERT(function.is_static());
+  ASSERT(function.is_declared_in_bytecode());
+  auto& result = Object::Handle(zone);
+  if (function.NumParameters() == 0) {
+    result = DartEntry::InvokeFunction(function, Object::empty_array());
+  } else {
+    ASSERT(function.NumParameters() == 1);
+    // <String>[]
+    const auto& arg0 = Array::Handle(
+        zone, Array::New(0, Type::Handle(zone, Type::StringType())));
+    const auto& args = Array::Handle(zone, Array::New(1));
+    args.SetAt(0, arg0);
+    result = DartEntry::InvokeFunction(function, args);
+  }
+  if (result.IsError()) {
+    Exceptions::PropagateError(Error::Cast(result));
+  }
+  return result.ptr();
+#else
+  Exceptions::ThrowUnsupportedError(
+      "Loading of dynamic modules is not supported.");
+  return Object::null();
+#endif  // defined(DART_DYNAMIC_MODULES)
+}
+
 DEFINE_NATIVE_ENTRY(InvocationMirror_unpackTypeArguments, 0, 2) {
   const TypeArguments& type_arguments =
       TypeArguments::CheckedHandle(zone, arguments->NativeArgAt(0));

runtime/lib/stacktrace.cc

@@ -46,7 +46,11 @@ static StackTracePtr CurrentStackTrace(Thread* thread,
   // Collect the frames.
   StackTraceUtils::CollectFrames(thread, skip_frames,
                                  [&](const StackTraceUtils::Frame& frame) {
-                                   code_array.Add(frame.code);
+                                   if (!frame.bytecode.IsNull()) {
+                                     code_array.Add(frame.bytecode);
+                                   } else {
+                                     code_array.Add(frame.code);
+                                   }
                                    pc_offset_array.Add(frame.pc_offset);
                                  });
 
@@ -72,6 +76,7 @@ static void AppendFrames(const GrowableObjectArray& code_list,
   StackFrame* frame = frames.NextFrame();
   ASSERT(frame != nullptr);  // We expect to find a dart invocation frame.
   Code& code = Code::Handle(zone);
+  Bytecode& bytecode = Bytecode::Handle(zone);
   for (; frame != nullptr; frame = frames.NextFrame()) {
     if (!frame->IsDartFrame()) {
       continue;
@@ -81,10 +86,20 @@ static void AppendFrames(const GrowableObjectArray& code_list,
       continue;
     }
 
-    code = frame->LookupDartCode();
-    const intptr_t pc_offset = frame->pc() - code.PayloadStart();
-    code_list.Add(code);
-    pc_offset_list->Add(pc_offset);
+    if (frame->is_interpreted()) {
+      bytecode = frame->LookupDartBytecode();
+      if (bytecode.function() == Function::null()) {
+        continue;
+      }
+      const intptr_t pc_offset = frame->pc() - bytecode.PayloadStart();
+      code_list.Add(bytecode);
+      pc_offset_list->Add(pc_offset);
+    } else {
+      code = frame->LookupDartCode();
+      const intptr_t pc_offset = frame->pc() - code.PayloadStart();
+      code_list.Add(code);
+      pc_offset_list->Add(pc_offset);
+    }
   }
 }
 

runtime/runtime_args.gni

@@ -74,6 +74,9 @@ declare_args() {
   # being built on platforms which have a problem linking in the Perfetto
   # library.
   dart_support_perfetto = true
+
+  # Whether to support dynamic loading and interpretation of Dart bytecode.
+  dart_dynamic_modules = false
 }
 
 declare_args() {

runtime/vm/app_snapshot.cc

@@ -1702,7 +1702,7 @@ class FunctionSerializationCluster : public SerializationCluster {
     } else if (kind == Snapshot::kFullJIT) {
       NOT_IN_PRECOMPILED(s->Push(func->untag()->unoptimized_code()));
       s->Push(func->untag()->code());
-      s->Push(func->untag()->ic_data_array());
+      s->Push(func->untag()->ic_data_array_or_bytecode());
     }
     if (kind != Snapshot::kFullAOT) {
       NOT_IN_PRECOMPILED(s->Push(func->untag()->positional_parameter_names()));
@@ -1737,7 +1737,7 @@ class FunctionSerializationCluster : public SerializationCluster {
       } else if (s->kind() == Snapshot::kFullJIT) {
         NOT_IN_PRECOMPILED(WriteCompressedField(func, unoptimized_code));
         WriteCompressedField(func, code);
-        WriteCompressedField(func, ic_data_array);
+        WriteCompressedField(func, ic_data_array_or_bytecode);
       }
 
       if (kind != Snapshot::kFullAOT) {
@@ -1917,7 +1917,7 @@ class FunctionDeserializationCluster : public DeserializationCluster {
       if (kind == Snapshot::kFullJIT) {
         func->untag()->unoptimized_code_ = static_cast<CodePtr>(d.ReadRef());
         func->untag()->code_ = static_cast<CodePtr>(d.ReadRef());
-        func->untag()->ic_data_array_ = static_cast<ArrayPtr>(d.ReadRef());
+        func->untag()->ic_data_array_or_bytecode_ = d.ReadRef();
       }
 #endif
 

runtime/vm/bootstrap_natives.h

@@ -268,6 +268,7 @@ namespace dart {
   V(Internal_extractTypeArguments, 2)                                          \
   V(Internal_prependTypeArguments, 4)                                          \
   V(Internal_boundsCheckForPartialInstantiation, 2)                            \
+  V(Internal_loadDynamicModule, 1)                                             \
   V(Internal_allocateOneByteString, 1)                                         \
   V(Internal_allocateTwoByteString, 1)                                         \
   V(Internal_writeIntoOneByteString, 3)                                        \