Skip to content

Commit 91be638

Browse files
johnniwinthercommit-bot@chromium.org
authored andcommitted
Add support for --verbosity in bazel/kernel_worker
Change-Id: If1c1cd2feb1c5341c3b7631dfe12888ce7eac249 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182221 Reviewed-by: David Morgan <[email protected]> Commit-Queue: Johnni Winther <[email protected]>
1 parent 237c842 commit 91be638

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

pkg/front_end/lib/src/api_unstable/bazel_worker.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export 'package:_fe_analyzer_shared/src/messages/diagnostic_message.dart'
4242
export 'package:_fe_analyzer_shared/src/messages/severity.dart' show Severity;
4343

4444
export '../api_prototype/compiler_options.dart'
45-
show parseExperimentalFlags, parseExperimentalArguments;
45+
show parseExperimentalFlags, parseExperimentalArguments, Verbosity;
4646

4747
export '../api_prototype/experimental_flags.dart'
4848
show ExperimentalFlag, parseExperimentalFlag;

utils/bazel/kernel_worker.dart

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,13 @@ final summaryArgsParser = new ArgParser()
147147
help: 'Enable a language experiment when invoking the CFE.')
148148
..addMultiOption('define', abbr: 'D')
149149
..addFlag('verbose', defaultsTo: false)
150-
..addFlag('sound-null-safety', defaultsTo: false);
150+
..addFlag('sound-null-safety', defaultsTo: false)
151+
..addOption('verbosity',
152+
defaultsTo: fe.Verbosity.defaultValue,
153+
help: 'Sets the verbosity level used for filtering messages during '
154+
'compilation.',
155+
allowed: fe.Verbosity.allowedValues,
156+
allowedHelp: fe.Verbosity.allowedValuesHelp);
151157

152158
class ComputeKernelResult {
153159
final bool succeeded;
@@ -257,6 +263,7 @@ Future<ComputeKernelResult> computeKernel(List<String> args,
257263
bool recordUsedInputs = parsedArgs["used-inputs"] != null;
258264
var environmentDefines = _parseEnvironmentDefines(parsedArgs['define']);
259265
var verbose = parsedArgs['verbose'] as bool;
266+
var verbosity = fe.Verbosity.parseArgument(parsedArgs['verbosity']);
260267

261268
if (parsedArgs['use-incremental-compiler']) {
262269
usingIncrementalCompiler = true;
@@ -321,7 +328,9 @@ Future<ComputeKernelResult> computeKernel(List<String> args,
321328
}
322329

323330
void onDiagnostic(fe.DiagnosticMessage message) {
324-
fe.printDiagnosticMessage(message, out.writeln);
331+
if (fe.Verbosity.shouldPrint(verbosity, message)) {
332+
fe.printDiagnosticMessage(message, out.writeln);
333+
}
325334
if (message.severity == fe.Severity.error) {
326335
succeeded = false;
327336
}

0 commit comments

Comments
 (0)