Skip to content

Commit 98e6322

Browse files
scheglovCommit Queue
authored andcommitted
Fix another TODO in elements printer, use 'name'.
Change-Id: I6696a4b559072b064ee16d22b8aad528b52eb6a0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/312704 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
1 parent 658de58 commit 98e6322

File tree

3 files changed

+604
-594
lines changed

3 files changed

+604
-594
lines changed

pkg/analyzer/test/src/summary/element_text.dart

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -622,8 +622,18 @@ class _ElementWriter {
622622
}
623623

624624
void _writeName(Element e) {
625-
// TODO(scheglov) Use 'name' everywhere.
626-
var name = e is ConstructorElement ? e.name : e.displayName;
625+
final String name;
626+
switch (e) {
627+
case ExtensionElement(name: null):
628+
name = '<null>';
629+
default:
630+
name = e.name!;
631+
}
632+
633+
if (e is PropertyAccessorElement && e.isSetter) {
634+
expect(name, endsWith('='));
635+
}
636+
627637
_sink.write(name);
628638
_sink.write(name.isNotEmpty ? ' @' : '@');
629639
_sink.write(e.nameOffset);

0 commit comments

Comments
 (0)