Do not allow void results in record literals

I also privatize all of the "repor"t methods, so the sort makes for a
big diff.

Fixes #52759

Change-Id: I0e7b2602e27ffe2eeab7688787d38ed039895b15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/341163
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: srawlins

pkg/analyzer/lib/src/dart/resolver/record_literal_resolver.dart

@@ -23,9 +23,52 @@ class RecordLiteralResolver {
 
   ErrorReporter get errorReporter => _resolver.errorReporter;
 
+  void resolve(
+    RecordLiteralImpl node, {
+    required DartType? contextType,
+  }) {
+    _resolveFields(node, contextType);
+    _buildType(node, contextType);
+
+    _reportDuplicateFieldDefinitions(node);
+    _reportInvalidFieldNames(node);
+  }
+
+  void _buildType(RecordLiteralImpl node, DartType? contextType) {
+    final positionalFields = <RecordTypePositionalFieldImpl>[];
+    final namedFields = <RecordTypeNamedFieldImpl>[];
+    for (final field in node.fields) {
+      final fieldType = field.typeOrThrow;
+      if (field is NamedExpressionImpl) {
+        namedFields.add(
+          RecordTypeNamedFieldImpl(
+            name: field.name.label.name,
+            type: fieldType,
+          ),
+        );
+      } else {
+        positionalFields.add(
+          RecordTypePositionalFieldImpl(
+            type: fieldType,
+          ),
+        );
+      }
+    }
+
+    _resolver.inferenceHelper.recordStaticType(
+      node,
+      RecordTypeImpl(
+        positionalFields: positionalFields,
+        namedFields: namedFields,
+        nullabilitySuffix: NullabilitySuffix.none,
+      ),
+      contextType: contextType,
+    );
+  }
+
   /// Report any named fields in the record literal [node] that use a previously
   /// defined name.
-  void reportDuplicateFieldDefinitions(RecordLiteralImpl node) {
+  void _reportDuplicateFieldDefinitions(RecordLiteralImpl node) {
     var usedNames = <String, NamedExpression>{};
     for (var field in node.fields) {
       if (field is NamedExpressionImpl) {
@@ -43,7 +86,7 @@ class RecordLiteralResolver {
   }
 
   /// Report any fields in the record literal [node] that use an invalid name.
-  void reportInvalidFieldNames(RecordLiteralImpl node) {
+  void _reportInvalidFieldNames(RecordLiteralImpl node) {
     var fields = node.fields;
     var positionalCount = 0;
     for (var field in fields) {
@@ -74,49 +117,6 @@ class RecordLiteralResolver {
     }
   }
 
-  void resolve(
-    RecordLiteralImpl node, {
-    required DartType? contextType,
-  }) {
-    _resolveFields(node, contextType);
-    _buildType(node, contextType);
-
-    reportDuplicateFieldDefinitions(node);
-    reportInvalidFieldNames(node);
-  }
-
-  void _buildType(RecordLiteralImpl node, DartType? contextType) {
-    final positionalFields = <RecordTypePositionalFieldImpl>[];
-    final namedFields = <RecordTypeNamedFieldImpl>[];
-    for (final field in node.fields) {
-      final fieldType = field.typeOrThrow;
-      if (field is NamedExpressionImpl) {
-        namedFields.add(
-          RecordTypeNamedFieldImpl(
-            name: field.name.label.name,
-            type: fieldType,
-          ),
-        );
-      } else {
-        positionalFields.add(
-          RecordTypePositionalFieldImpl(
-            type: fieldType,
-          ),
-        );
-      }
-    }
-
-    _resolver.inferenceHelper.recordStaticType(
-      node,
-      RecordTypeImpl(
-        positionalFields: positionalFields,
-        namedFields: namedFields,
-        nullabilitySuffix: NullabilitySuffix.none,
-      ),
-      contextType: contextType,
-    );
-  }
-
   void _resolveField(ExpressionImpl field, DartType? contextType) {
     _resolver.analyzeExpression(field, contextType);
     field = _resolver.popRewrite()!;
@@ -128,6 +128,11 @@ class RecordLiteralResolver {
         field.expression.staticType = contextType;
       }
     }
+
+    if (field.typeOrThrow is VoidType) {
+      errorReporter.reportErrorForNode(
+          CompileTimeErrorCode.USE_OF_VOID_RESULT, field);
+    }
   }
 
   void _resolveFields(RecordLiteralImpl node, DartType? contextType) {

pkg/analyzer/test/src/diagnostics/use_of_void_result_test.dart

@@ -239,6 +239,26 @@ void f(void x) {
     ]);
   }
 
+  test_recordLiteral_namedField() async {
+    await assertErrorsInCode('''
+void f(void x) {
+  (one: x,);
+}
+''', [
+      error(CompileTimeErrorCode.USE_OF_VOID_RESULT, 20, 6),
+    ]);
+  }
+
+  test_recordLiteral_positionalField() async {
+    await assertErrorsInCode('''
+void f(void x) {
+  (x,);
+}
+''', [
+      error(CompileTimeErrorCode.USE_OF_VOID_RESULT, 20, 1),
+    ]);
+  }
+
   test_switchStatement_expression() async {
     await assertErrorsInCode('''
 void f(void x) {