Make DartCompletionRequestImpl.from() synchronous.

We give it (indirectly) ResolvedUnitResult, so it does not do any
async operation.

Change-Id: I2d29925fd20ea14bd984e6c3c226de466a03fb39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217824
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analysis_server/lib/src/cider/completion.dart

@@ -78,7 +78,7 @@ class CiderCompletionComputer {
         CompletionPerformance(),
       );
 
-      _dartCompletionRequest = await DartCompletionRequestImpl.from(
+      _dartCompletionRequest = DartCompletionRequestImpl.from(
         completionRequest,
       );
 

pkg/analysis_server/lib/src/domain_completion.dart

@@ -102,7 +102,7 @@ class CompletionDomainHandler extends AbstractRequestHandler {
 
       var contributorTag = 'computeSuggestions - ${manager.runtimeType}';
       await perf.runAsync(contributorTag, (performance) async {
-        var dartRequest = await DartCompletionRequestImpl.from(
+        var dartRequest = DartCompletionRequestImpl.from(
           request,
           dartdocDirectiveInfo: server.getDartdocDirectiveInfoFor(
             request.result,

pkg/analysis_server/lib/src/domains/execution/completion.dart

@@ -76,7 +76,7 @@ class RuntimeCompletionComputer {
       CompletionPerformance(),
     );
 
-    var dartRequest = await DartCompletionRequestImpl.from(request);
+    var dartRequest = DartCompletionRequestImpl.from(request);
 
     var suggestions = await request.performance.runRequestOperation(
       (performance) async {

pkg/analysis_server/lib/src/lsp/handlers/handler_completion.dart

@@ -213,7 +213,7 @@ class CompletionHandler
           CompletionRequestImpl(unit, offset, performance);
       final directiveInfo =
           server.getDartdocDirectiveInfoFor(completionRequest.result);
-      final dartCompletionRequest = await DartCompletionRequestImpl.from(
+      final dartCompletionRequest = DartCompletionRequestImpl.from(
         completionRequest,
         dartdocDirectiveInfo: directiveInfo,
         completionPreference: CompletionPreference.replace,

pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

@@ -364,12 +364,12 @@ class DartCompletionRequestImpl implements DartCompletionRequest {
   /// Return a newly created completion request based on the given [request].
   /// This method will throw [AbortCompletion] if the completion request has
   /// been aborted.
-  static Future<DartCompletionRequestImpl> from(
+  static DartCompletionRequestImpl from(
     CompletionRequest request, {
     DartdocDirectiveInfo? dartdocDirectiveInfo,
     CompletionPreference completionPreference = CompletionPreference.insert,
     DocumentationCache? documentationCache,
-  }) async {
+  }) {
     request.checkAborted();
 
     var result = request.result;

pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

@@ -537,7 +537,7 @@ abstract class _BaseDartCompletionContributorTest extends AbstractContextTest {
     return await baseRequest.performance.runRequestOperation(
       (performance) async {
         // Build the request
-        var request = await DartCompletionRequestImpl.from(
+        var request = DartCompletionRequestImpl.from(
           baseRequest,
           dartdocDirectiveInfo: dartdocInfo,
         );

pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart

@@ -57,12 +57,7 @@ part 'test.dart';
         completionOffset,
         CompletionPerformance());
     await baseRequest.performance.runRequestOperation((performance) async {
-      var requestCompleter = Completer<DartCompletionRequest>();
-      DartCompletionRequestImpl.from(baseRequest)
-          .then((DartCompletionRequest request) {
-        requestCompleter.complete(request);
-      });
-      request = await performAnalysis(200, requestCompleter);
+      request = DartCompletionRequestImpl.from(baseRequest);
     });
 
     var directives = request.target.unit.directives;

pkg/analysis_server/test/src/services/completion/dart/suggestion_builder_test.dart

@@ -29,7 +29,7 @@ class ContextTypeTest extends AbstractSingleUnitTest {
   }
 
   Future<CompletionSuggestion> forTopLevelFunction(String functionName) async {
-    var request = await DartCompletionRequestImpl.from(
+    var request = DartCompletionRequestImpl.from(
       CompletionRequestImpl(testAnalysisResult, 0, CompletionPerformance()),
     );
     var builder = SuggestionBuilder(request);

pkg/analysis_server/test/stress/completion/completion_runner.dart

@@ -100,7 +100,7 @@ class CompletionRunner {
 
           timer.start();
           var request = CompletionRequestImpl(result, offset, statistics);
-          var dartRequest = await DartCompletionRequestImpl.from(request);
+          var dartRequest = DartCompletionRequestImpl.from(request);
           var suggestions = await request.performance.runRequestOperation(
             (performance) async {
               return await contributor.computeSuggestions(

pkg/analysis_server/tool/code_completion/completion_metrics.dart

@@ -1208,7 +1208,7 @@ class CompletionMetricsComputer {
           availableSuggestionsParams]) async {
     List<protocol.CompletionSuggestion> suggestions;
 
-    var dartRequest = await DartCompletionRequestImpl.from(
+    var dartRequest = DartCompletionRequestImpl.from(
       request,
       dartdocDirectiveInfo: dartdocDirectiveInfo,
       documentationCache: documentationCache,
@@ -1385,7 +1385,7 @@ class CompletionMetricsComputer {
           late List<protocol.CompletionSuggestion> suggestions;
           await request.performance.runRequestOperation(
             (performance) async {
-              var dartRequest = await DartCompletionRequestImpl.from(
+              var dartRequest = DartCompletionRequestImpl.from(
                 request,
                 documentationCache: documentationCache,
               );