prefer_void_to_null: not for variable declarations (dart-archive/linter#4210)

Author: srawlins

lib/src/rules/prefer_void_to_null.dart

@@ -140,6 +140,13 @@ class _Visitor extends SimpleAstVisitor<void> {
       return;
     }
 
+    if (parent is VariableDeclarationList &&
+        node == parent.type &&
+        parent.parent is! FieldDeclaration) {
+      // We should not recommend to use `void` for local or top-level variables.
+      return;
+    }
+
     // <Null>[] or <Null, Null>{}
     if (parent is TypeArgumentList) {
       var literal = parent.parent;

test/rules/prefer_void_to_null_test.dart

@@ -35,6 +35,20 @@ void f(int a) {
     case var _ as Null:
   }
 }
+''');
+  }
+
+  test_localVariable() async {
+    await assertNoDiagnostics(r'''
+void f() {
+  Null _;
+}
+''');
+  }
+
+  test_topLevelVariable() async {
+    await assertNoDiagnostics(r'''
+Null a;
 ''');
   }
 }

test_data/rules/prefer_void_to_null.dart

@@ -52,8 +52,6 @@ class F implements E {
 }
 
 void void_; // OK
-Null null_; // LINT
-core.Null core_null; // LINT
 Future<void>? future_void; // OK
 Future<Null>? future_null; // LINT
 Future<core.Null>? future_core_null; // LINT
@@ -72,8 +70,6 @@ void Function(Future<Null>)? voidFunctionFutureNull; // LINT
 
 usage() {
   void void_; // OK
-  Null null_; // LINT
-  core.Null core_null; // LINT
   Future<void>? future_void; // OK
   Future<Null> future_null; // LINT
   Future<core.Null> future_core_null; // LINT
@@ -152,8 +148,6 @@ class AsMembers {
 
   void usage() {
     void void_; // OK
-    Null null_; // LINT
-    core.Null core_null; // LINT
     Future<void>? future_void; // OK
     Future<Null> future_null; // LINT
     Future<core.Null> future_core_null; // LINT