Skip to content

Commit a19c07f

Browse files
pqCommit Queue
authored and
Commit Queue
committed
guard against empty entity lists
Unable to repro the reported issue, but this will at least protect against the exception. Fixes: https://dart-review.googlesource.com/c/sdk/+/359280 Change-Id: I712f9b92879ca6b80b2f1004206e4f77a3178a47 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/359280 Reviewed-by: Keerti Parthasarathy <[email protected]> Commit-Queue: Phil Quitslund <[email protected]>
1 parent 970582e commit a19c07f

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

pkg/analysis_server/lib/src/services/correction/dart/split_multiple_declarations.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ class SplitMultipleDeclarations extends ResolvedCorrectionProducer {
3434
final hasMetadata = variableList.metadata.isNotEmpty;
3535

3636
final parent = variableList.parent;
37+
// TODO(sstasi95): consider fields
3738
final hasParentMetadata =
3839
(parent is TopLevelVariableDeclaration) && parent.metadata.isNotEmpty;
3940

@@ -49,6 +50,10 @@ class SplitMultipleDeclarations extends ResolvedCorrectionProducer {
4950

5051
final entities = variableList.childEntities
5152
.where((e) => e is KeywordToken || e is NamedType);
53+
if (entities.isEmpty) {
54+
return;
55+
}
56+
5257
final entitiesRange = range.startEnd(entities.first, entities.last);
5358
final keywordsAndType = utils.getRangeText(entitiesRange);
5459

0 commit comments

Comments
 (0)