Skip to content

Commit a614871

Browse files
scheglovcommit-bot@chromium.org
authored andcommitted
Annotate two failing inference tests with the corresponding issue.
[email protected], [email protected] Bug: #25824 Change-Id: I485f87f526c1251363349e9d354eefdc57d24120 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148200 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
1 parent fcb8ac8 commit a614871

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

pkg/analyzer/test/src/task/strong/inferred_type_test.dart

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4035,10 +4035,9 @@ var v = f<dynamic>(() { return 1; });
40354035
_assertTypeStr(v.type, 'List<dynamic>');
40364036
}
40374037

4038-
@failingTest
4038+
@FailingTest(issue: 'https://github.com/dart-lang/sdk/issues/25824')
40394039
test_unsafeBlockClosureInference_functionCall_explicitDynamicParam_viaExpr1() async {
4040-
// Note: (f<dynamic>) is not properly resulting in an instantiated
4041-
// function type due to dartbug.com/25824.
4040+
// Note: (f<dynamic>) is not a valid syntax.
40424041
var mainUnit = await checkFileElement('''
40434042
List<T> f<T>(T g()) => <T>[g()];
40444043
var v = (f<dynamic>)(() { return 1; });
@@ -4068,10 +4067,9 @@ var v = f<int>(() { return 1; });
40684067
_assertTypeStr(v.type, 'List<int>');
40694068
}
40704069

4071-
@failingTest
4070+
@FailingTest(issue: 'https://github.com/dart-lang/sdk/issues/25824')
40724071
test_unsafeBlockClosureInference_functionCall_explicitTypeParam_viaExpr1() async {
4073-
// TODO(paulberry): for some reason (f<int>) is not properly resulting
4074-
// in an instantiated function type.
4072+
// Note: (f<int>) is not a valid syntax.
40754073
var mainUnit = await checkFileElement('''
40764074
List<T> f<T>(T g()) => <T>[g()];
40774075
var v = (f<int>)(() { return 1; });

0 commit comments

Comments
 (0)