[analyzer] Remove generated constant evaluator and its tests.

The generated constant evaluator is not being used and is removed by
this CL. All imports of the deleted evaluator will import the more
direct dependency and tests are moved to `evaluation_test.dart`.

Change-Id: Ie435d289bd85256419f67407b36af0375661f335
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324342
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: kallentu

pkg/analyzer/lib/src/context/context.dart

@@ -2,9 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:analyzer/dart/analysis/declared_variables.dart';
 import 'package:analyzer/src/dart/element/type_provider.dart';
 import 'package:analyzer/src/dart/element/type_system.dart';
-import 'package:analyzer/src/generated/constant.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/source.dart';
 

pkg/analyzer/lib/src/dart/constant/evaluation.dart

@@ -4,10 +4,12 @@
 
 import 'dart:collection';
 
+import 'package:analyzer/dart/analysis/declared_variables.dart';
 import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/dart/ast/syntactic_entity.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
+import 'package:analyzer/dart/constant/value.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/nullability_suffix.dart';
 import 'package:analyzer/dart/element/type.dart';
@@ -20,14 +22,15 @@ import 'package:analyzer/src/dart/ast/token.dart';
 import 'package:analyzer/src/dart/constant/from_environment_evaluator.dart';
 import 'package:analyzer/src/dart/constant/has_type_parameter_reference.dart';
 import 'package:analyzer/src/dart/constant/potentially_constant.dart';
+import 'package:analyzer/src/dart/constant/utilities.dart';
+import 'package:analyzer/src/dart/constant/value.dart';
 import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/dart/element/member.dart';
 import 'package:analyzer/src/dart/element/type.dart';
 import 'package:analyzer/src/dart/element/type_algebra.dart';
 import 'package:analyzer/src/dart/element/type_system.dart' show TypeSystemImpl;
 import 'package:analyzer/src/diagnostic/diagnostic.dart';
 import 'package:analyzer/src/error/codes.dart';
-import 'package:analyzer/src/generated/constant.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/java_core.dart';
 import 'package:analyzer/src/task/api/model.dart';

pkg/analyzer/lib/src/dart/constant/value.dart

@@ -904,7 +904,7 @@ class DartObjectImpl implements DartObject, Constant {
   Map<DartObjectImpl, DartObjectImpl>? toMapValue() {
     final state = this.state;
     if (state is MapState) {
-      return state._entries;
+      return state.entries;
     }
     return null;
   }
@@ -913,7 +913,7 @@ class DartObjectImpl implements DartObject, Constant {
   Set<DartObjectImpl>? toSetValue() {
     final state = this.state;
     if (state is SetState) {
-      return state._elements;
+      return state.elements;
     }
     return null;
   }
@@ -2491,16 +2491,16 @@ class ListState extends InstanceState {
 /// The state of an object representing a map.
 class MapState extends InstanceState {
   /// The entries in the map.
-  final Map<DartObjectImpl, DartObjectImpl> _entries;
+  final Map<DartObjectImpl, DartObjectImpl> entries;
 
   /// Initialize a newly created state to represent a map with the given
   /// [entries].
-  MapState(this._entries);
+  MapState(this.entries);
 
   @override
   int get hashCode {
     int value = 0;
-    for (DartObjectImpl key in _entries.keys.toSet()) {
+    for (DartObjectImpl key in entries.keys.toSet()) {
       value = (value << 3) ^ key.hashCode;
     }
     return value;
@@ -2512,15 +2512,15 @@ class MapState extends InstanceState {
   @override
   bool operator ==(Object other) {
     if (other is MapState) {
-      Map<DartObjectImpl, DartObjectImpl> otherElements = other._entries;
-      int count = _entries.length;
+      Map<DartObjectImpl, DartObjectImpl> otherElements = other.entries;
+      int count = entries.length;
       if (otherElements.length != count) {
         return false;
       } else if (count == 0) {
         return true;
       }
-      for (DartObjectImpl key in _entries.keys) {
-        var value = _entries[key];
+      for (DartObjectImpl key in entries.keys) {
+        var value = entries[key];
         var otherValue = otherElements[key];
         if (value != otherValue) {
           return false;
@@ -2552,7 +2552,7 @@ class MapState extends InstanceState {
     StringBuffer buffer = StringBuffer();
     buffer.write('{');
     bool first = true;
-    _entries.forEach((DartObjectImpl key, DartObjectImpl value) {
+    entries.forEach((DartObjectImpl key, DartObjectImpl value) {
       if (first) {
         first = false;
       } else {
@@ -2763,16 +2763,16 @@ class RecordState extends InstanceState {
 /// The state of an object representing a set.
 class SetState extends InstanceState {
   /// The elements of the set.
-  final Set<DartObjectImpl> _elements;
+  final Set<DartObjectImpl> elements;
 
   /// Initialize a newly created state to represent a set with the given
   /// [elements].
-  SetState(this._elements);
+  SetState(this.elements);
 
   @override
   int get hashCode {
     int value = 0;
-    for (DartObjectImpl element in _elements) {
+    for (DartObjectImpl element in elements) {
       value = (value << 3) ^ element.hashCode;
     }
     return value;
@@ -2784,16 +2784,16 @@ class SetState extends InstanceState {
   @override
   bool operator ==(Object other) {
     if (other is SetState) {
-      List<DartObjectImpl> elements = _elements.toList();
-      List<DartObjectImpl> otherElements = other._elements.toList();
-      int count = elements.length;
+      List<DartObjectImpl> currentElements = elements.toList();
+      List<DartObjectImpl> otherElements = other.elements.toList();
+      int count = currentElements.length;
       if (otherElements.length != count) {
         return false;
       } else if (count == 0) {
         return true;
       }
       for (int i = 0; i < count; i++) {
-        if (elements[i] != otherElements[i]) {
+        if (currentElements[i] != otherElements[i]) {
           return false;
         }
       }
@@ -2823,7 +2823,7 @@ class SetState extends InstanceState {
     StringBuffer buffer = StringBuffer();
     buffer.write('{');
     bool first = true;
-    for (var element in _elements) {
+    for (var element in elements) {
       if (first) {
         first = false;
       } else {

pkg/analyzer/lib/src/error/best_practices_verifier.dart

@@ -4,10 +4,12 @@
 
 import 'dart:collection';
 
+import 'package:analyzer/dart/analysis/declared_variables.dart';
 import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/dart/ast/syntactic_entity.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
+import 'package:analyzer/dart/constant/value.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/nullability_suffix.dart';
 import 'package:analyzer/dart/element/type.dart';
@@ -32,7 +34,6 @@ import 'package:analyzer/src/error/doc_comment_verifier.dart';
 import 'package:analyzer/src/error/error_handler_verifier.dart';
 import 'package:analyzer/src/error/must_call_super_verifier.dart';
 import 'package:analyzer/src/error/null_safe_api_verifier.dart';
-import 'package:analyzer/src/generated/constant.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/lint/linter.dart';
 import 'package:analyzer/src/workspace/workspace.dart';

pkg/analyzer/lib/src/error/dead_code_verifier.dart

@@ -11,12 +11,13 @@ import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/error/listener.dart';
 import 'package:analyzer/source/source_range.dart';
+import 'package:analyzer/src/dart/constant/evaluation.dart';
+import 'package:analyzer/src/dart/constant/value.dart';
 import 'package:analyzer/src/dart/element/type_system.dart';
 import 'package:analyzer/src/dart/resolver/exit_detector.dart';
 import 'package:analyzer/src/dart/resolver/flow_analysis_visitor.dart';
 import 'package:analyzer/src/dart/resolver/scope.dart';
 import 'package:analyzer/src/error/codes.dart';
-import 'package:analyzer/src/generated/constant.dart';
 import 'package:collection/collection.dart';
 
 typedef _CatchClausesVerifierReporter = void Function(

pkg/analyzer/lib/src/generated/constant.dart

@@ -7,14 +7,14 @@ import 'dart:typed_data';
 import 'package:_fe_analyzer_shared/src/scanner/string_canonicalizer.dart';
 import 'package:analyzer/dart/analysis/analysis_options.dart';
 import 'package:analyzer/dart/analysis/code_style_options.dart';
+import 'package:analyzer/dart/analysis/declared_variables.dart';
 import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/instrumentation/instrumentation.dart';
 import 'package:analyzer/source/error_processor.dart';
 import 'package:analyzer/src/analysis_options/code_style_options.dart';
 import 'package:analyzer/src/dart/analysis/experiments.dart';
 import 'package:analyzer/src/dart/sdk/sdk.dart';
-import 'package:analyzer/src/generated/constant.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/services/lint.dart';
 import 'package:analyzer/src/summary/api_signature.dart';

pkg/analyzer/lib/src/generated/engine.dart

@@ -11,17 +11,18 @@ import 'package:_fe_analyzer_shared/src/exhaustiveness/space.dart';
 import 'package:_fe_analyzer_shared/src/exhaustiveness/static_type.dart';
 import 'package:_fe_analyzer_shared/src/exhaustiveness/types.dart';
 import 'package:analyzer/dart/analysis/features.dart';
+import 'package:analyzer/dart/constant/value.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/nullability_suffix.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/src/dart/ast/ast.dart';
 import 'package:analyzer/src/dart/ast/extensions.dart';
+import 'package:analyzer/src/dart/constant/value.dart';
 import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/dart/element/replacement_visitor.dart';
 import 'package:analyzer/src/dart/element/type_algebra.dart';
 import 'package:analyzer/src/dart/element/type_system.dart';
 import 'package:analyzer/src/dart/resolver/variance.dart';
-import 'package:analyzer/src/generated/constant.dart';
 
 /// The buffer that accumulates types and elements as is, so that they
 /// can be written latter into Dart code that considers imports. It also

pkg/analyzer/lib/src/generated/exhaustiveness.dart

@@ -2,10 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:analyzer/dart/analysis/declared_variables.dart';
 import 'package:analyzer/dart/element/type_provider.dart';
 import 'package:analyzer/src/dart/constant/from_environment_evaluator.dart';
+import 'package:analyzer/src/dart/constant/value.dart';
 import 'package:analyzer/src/dart/element/type_system.dart';
-import 'package:analyzer/src/generated/constant.dart';
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';