Skip to content

Commit b3a1299

Browse files
srujzscommit-bot@chromium.org
authored andcommitted
Revert "Remove html_individual_config from lib_2/html tests"
This reverts commit ccd2f7e. Reason for revert: CL broke other targets outside of try jobs Original change's description: > Remove html_individual_config from lib_2/html tests > > Change-Id: I4a9684096f8e6d6a9af95f8a160c532e16f1be93 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137247 > Reviewed-by: Bob Nystrom <[email protected]> [email protected],[email protected] Change-Id: I762f7b7eec167dab3c96a03bd8df07b1c6ad7876 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137431 Reviewed-by: Srujan Gaddam <[email protected]> Commit-Queue: Srujan Gaddam <[email protected]>
1 parent 82236bd commit b3a1299

17 files changed

+51
-0
lines changed

tests/lib_2/html/canvasrenderingcontext2d_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ library canvas_rendering_context_2d_test;
77
import 'dart:html';
88
import 'dart:math';
99

10+
import 'package:unittest/html_individual_config.dart';
1011
import 'package:unittest/unittest.dart';
1112

1213
// Some rounding errors in the browsers.
@@ -80,6 +81,8 @@ void expectPixelUnfilled(int x, int y) {
8081
}
8182

8283
main() {
84+
useHtmlIndividualConfiguration();
85+
8386
group('pixel_manipulation', () {
8487
setUp(setupFunc);
8588
tearDown(tearDownFunc);

tests/lib_2/html/custom/entered_left_view_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import 'dart:async';
88
import 'dart:html';
99
import 'dart:js' as js;
1010

11+
import 'package:unittest/html_individual_config.dart';
1112
import 'package:unittest/unittest.dart';
1213

1314
import 'utils.dart';
@@ -64,6 +65,8 @@ class FooOldCallbacks extends HtmlElement {
6465
}
6566

6667
main() {
68+
useHtmlIndividualConfiguration();
69+
6770
// Adapted from Blink's
6871
// fast/dom/custom/attached-detached-document.html test.
6972

tests/lib_2/html/custom/regress_194523002_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
// Regression test for CL 194523002.
66
import 'dart:html';
77

8+
import 'package:unittest/html_individual_config.dart';
89
import 'package:unittest/unittest.dart';
910

1011
import 'utils.dart';
@@ -16,6 +17,8 @@ class A extends HtmlElement {
1617
}
1718

1819
main() {
20+
useHtmlIndividualConfiguration();
21+
1922
// Adapted from Blink's
2023
// fast/dom/custom/constructor-calls-created-synchronously test.
2124

tests/lib_2/html/custom_element_method_clash_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ library custom_elements_method_clash;
66

77
import 'dart:async';
88
import 'dart:html';
9+
import 'package:unittest/html_individual_config.dart';
910
import 'package:unittest/unittest.dart';
1011
import 'utils.dart';
1112

@@ -21,6 +22,8 @@ class CustomElement extends HtmlElement {
2122
}
2223

2324
main() {
25+
useHtmlIndividualConfiguration();
26+
2427
setUp(() => customElementsReady);
2528

2629
group('test', () {

tests/lib_2/html/custom_element_name_clash_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ library custom_elements_name_clash;
66

77
import 'dart:async';
88
import 'dart:html';
9+
import 'package:unittest/html_individual_config.dart';
910
import 'package:unittest/unittest.dart';
1011
import 'utils.dart';
1112

@@ -19,6 +20,8 @@ class CustomElement extends HtmlElement {
1920
}
2021

2122
main() {
23+
useHtmlIndividualConfiguration();
24+
2225
setUp(() => customElementsReady);
2326

2427
group('test', () {

tests/lib_2/html/custom_elements_23127_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ library custom_elements_23127_test;
1010

1111
import 'dart:async';
1212
import 'dart:html';
13+
import 'package:unittest/html_individual_config.dart';
1314
import 'package:unittest/unittest.dart';
1415
import 'utils.dart';
1516

@@ -87,6 +88,8 @@ class C2T extends B2T {
8788
var callTwice;
8889

8990
main() {
91+
useHtmlIndividualConfiguration();
92+
9093
setUp(() => customElementsReady);
9194

9295
callTwice = (f) {

tests/lib_2/html/custom_elements_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ library custom_elements_test;
66

77
import 'dart:async';
88
import 'dart:html';
9+
import 'package:unittest/html_individual_config.dart';
910
import 'package:unittest/unittest.dart';
1011
import 'utils.dart';
1112

@@ -39,6 +40,8 @@ String get nextTag => 'x-type${nextTagId++}';
3940
class NotAnElement {}
4041

4142
main() {
43+
useHtmlIndividualConfiguration();
44+
4245
setUp(() => customElementsReady);
4346

4447
group('register', () {

tests/lib_2/html/form_data_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,14 @@
55
library FormDataTest;
66

77
import 'package:unittest/unittest.dart';
8+
import 'package:unittest/html_individual_config.dart';
89
import 'dart:html';
910

1011
void main() {
1112
// TODO(efortuna): This is a bad test. Revisit when we have tests that can run
1213
// both a server and fire up a browser.
14+
useHtmlIndividualConfiguration();
15+
1316
group('supported', () {
1417
test('supported', () {
1518
expect(FormData.supported, isTrue);

tests/lib_2/html/history_hash_change_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
library HistoryTest;
22

33
import 'package:unittest/unittest.dart';
4+
import 'package:unittest/html_individual_config.dart';
45
import 'dart:html';
56
import 'dart:async';
67

78
main() {
9+
useHtmlIndividualConfiguration();
10+
811
test('supported', () {
912
expect(HashChangeEvent.supported, true);
1013
});

tests/lib_2/html/history_history_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
library HistoryTest;
22

33
import 'package:unittest/unittest.dart';
4+
import 'package:unittest/html_individual_config.dart';
45
import 'dart:html';
56
import 'dart:async';
67

78
main() {
9+
useHtmlIndividualConfiguration();
10+
811
var expectation = History.supportsState ? returnsNormally : throws;
912

1013
test('pushState', () {

tests/lib_2/html/history_supports_tests.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
library HistoryTest;
22

33
import 'package:unittest/unittest.dart';
4+
import 'package:unittest/html_individual_config.dart';
45
import 'dart:html';
56
import 'dart:async';
67

78
main() {
9+
useHtmlIndividualConfiguration();
10+
811
test('supportsState', () {
912
expect(History.supportsState, true);
1013
});

tests/lib_2/html/history_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
library HistoryTest;
22

33
import 'package:unittest/unittest.dart';
4+
import 'package:unittest/html_individual_config.dart';
45
import 'dart:html';
56
import 'dart:async';
67

78
main() {
9+
useHtmlIndividualConfiguration();
10+
811
group('supported_state', () {
912
test('supportsState', () {
1013
expect(History.supportsState, true);

tests/lib_2/html/indexeddb_1_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
library IndexedDB1Test;
22

33
import 'package:unittest/unittest.dart';
4+
import 'package:unittest/html_individual_config.dart';
45
import 'dart:async';
56
import 'dart:html' as html;
67
import 'dart:math' as math;
@@ -153,6 +154,8 @@ void testTypes(testFunction) {
153154
}
154155

155156
main() {
157+
useHtmlIndividualConfiguration();
158+
156159
// Test that indexed_db is properly flagged as supported or not.
157160
// Note that the rest of the indexed_db tests assume that this has been
158161
// checked.

tests/lib_2/html/interactive_geolocation_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,12 @@ library interactive_test;
77
import 'dart:async';
88
import 'dart:html';
99
import 'package:unittest/unittest.dart';
10+
import 'package:unittest/html_individual_config.dart';
1011
import 'utils.dart';
1112

1213
main() {
14+
useHtmlIndividualConfiguration();
15+
1316
test('getCurrentPosition', () {
1417
return window.navigator.geolocation.getCurrentPosition().then((position) {
1518
expect(position.coords.latitude, isNotNull);

tests/lib_2/html/interactive_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,12 @@ library interactive_test;
77
import 'dart:async';
88
import 'dart:html';
99
import 'package:unittest/unittest.dart';
10+
import 'package:unittest/html_individual_config.dart';
1011
import 'utils.dart';
1112

1213
main() {
14+
useHtmlIndividualConfiguration();
15+
1316
group('KeyEvent', () {
1417
keydownHandlerTest(KeyEvent e) {
1518
document.body.innerHtml =

tests/lib_2/html/worker_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,12 @@
55
library worker_test;
66

77
import 'package:unittest/unittest.dart';
8+
import 'package:unittest/html_individual_config.dart';
89
import 'dart:html';
910

1011
main() {
12+
useHtmlIndividualConfiguration();
13+
1114
group('supported', () {
1215
test('supported', () {
1316
expect(Worker.supported, isTrue);

tests/lib_2/html/xhr_cross_origin_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
library XHRCrossOriginTest;
66

77
import 'package:unittest/unittest.dart';
8+
import 'package:unittest/html_individual_config.dart';
89
import 'dart:html';
910
import "dart:convert";
1011

@@ -25,6 +26,8 @@ int get crossOriginPort {
2526
}
2627

2728
main() {
29+
useHtmlIndividualConfiguration();
30+
2831
group('supported', () {
2932
test('supported', () {
3033
expect(HttpRequest.supportsCrossOrigin, isTrue);

0 commit comments

Comments
 (0)