Issue 52327. Don't report SDK_VERSION_SINCE when pubspec.yaml has exact version of SDK that is greater than the required.

scheglov · Commit Queue · commit c4aa75408d86 · 2023-05-10T15:41:54.000Z
Bug: #52327 Change-Id: I20b86173d59fb725cb715b624348d5ddd289e0f2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302443 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com>
diff --git a/pkg/analyzer/lib/src/hint/sdk_constraint_verifier.dart b/pkg/analyzer/lib/src/hint/sdk_constraint_verifier.dart
@@ -456,7 +456,7 @@ extension on VersionConstraint {
   bool requiresAtLeast(Version version) {
     final self = this;
     if (self is Version) {
-      return self == version;
+      return self >= version;
     }
     if (self is VersionRange) {
       final min = self.min;
diff --git a/pkg/analyzer/test/src/diagnostics/sdk_version_since_test.dart b/pkg/analyzer/test/src/diagnostics/sdk_version_since_test.dart
@@ -608,9 +608,7 @@ class A {}
 import 'dart:foo';
 
 void f(A a) {}
-''', expectedErrors: [
-      error(WarningCode.SDK_VERSION_SINCE, 27, 1),
-    ]);
+''');
   }
 
   test_constraints_exact_less() async {

Original file line number	Diff line number	Diff line change
`@@ -456,7 +456,7 @@ extension on VersionConstraint {`
`456`	`456`	`bool requiresAtLeast(Version version) {`
`457`	`457`	`final self = this;`
`458`	`458`	`if (self is Version) {`
`459`		`- return self == version;`
	`459`	`+ return self >= version;`
`460`	`460`	`}`
`461`	`461`	`if (self is VersionRange) {`
`462`	`462`	`final min = self.min;`
Original file line number	Diff line number	Diff line change
`@@ -608,9 +608,7 @@ class A {}`
`608`	`608`	`import 'dart:foo';`
`609`	`609`
`610`	`610`	`void f(A a) {}`
`611`		`-''', expectedErrors: [`
`612`		`- error(WarningCode.SDK_VERSION_SINCE, 27, 1),`
`613`		`- ]);`
	`611`	`+''');`
`614`	`612`	`}`
`615`	`613`
`616`	`614`	`test_constraints_exact_less() async {`