Macro. Add more operation performance details.

Bug: #55784
Change-Id: Ibe83b4eee8bbf47ee79193244f9233cdb1b6aece
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373161
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -1593,7 +1593,6 @@ class AnalysisDriver {
     );
 
     _fsState = FileSystemState(
-      _logger,
       _byteStore,
       _resourceProvider,
       name,

pkg/analyzer/lib/src/dart/analysis/file_state.dart

@@ -22,7 +22,6 @@ import 'package:analyzer/src/dart/analysis/defined_names.dart';
 import 'package:analyzer/src/dart/analysis/feature_set_provider.dart';
 import 'package:analyzer/src/dart/analysis/file_content_cache.dart';
 import 'package:analyzer/src/dart/analysis/library_graph.dart';
-import 'package:analyzer/src/dart/analysis/performance_logger.dart';
 import 'package:analyzer/src/dart/analysis/referenced_names.dart';
 import 'package:analyzer/src/dart/analysis/unlinked_api_signature.dart';
 import 'package:analyzer/src/dart/analysis/unlinked_data.dart';
@@ -779,11 +778,17 @@ class FileState {
       performance: performance,
     ).unit;
 
-    return _fsState._logger.run('Create unlinked for $path', () {
-      var unlinkedUnit = serializeAstUnlinked2(
-        unit,
-        exists: exists,
-        isDartCore: uriStr == 'dart:core',
+    return performance.run('compute', (performance) {
+      var unlinkedUnit = performance.run(
+        'serializeAstUnlinked2',
+        (performance) {
+          return serializeAstUnlinked2(
+            unit,
+            exists: exists,
+            isDartCore: uriStr == 'dart:core',
+            performance: performance,
+          );
+        },
       );
       var definedNames = computeDefinedNames(unit);
       var referencedNames = computeReferencedNames(unit);
@@ -914,6 +919,7 @@ class FileState {
     CompilationUnit unit, {
     required bool exists,
     required bool isDartCore,
+    required OperationPerformanceImpl performance,
   }) {
     UnlinkedLibraryDirective? libraryDirective;
     UnlinkedLibraryAugmentationDirective? libraryAugmentationDirective;
@@ -1054,12 +1060,15 @@ class FileState {
       }
     }
 
-    var apiSignature = ApiSignature();
-    apiSignature.addBytes(computeUnlinkedApiSignature(unit));
-    apiSignature.addBool(exists);
+    var apiSignature = performance.run('apiSignature', (performance) {
+      var signatureBuilder = ApiSignature();
+      signatureBuilder.addBytes(computeUnlinkedApiSignature(unit));
+      signatureBuilder.addBool(exists);
+      return signatureBuilder.toByteList();
+    });
 
     return UnlinkedUnit(
-      apiSignature: apiSignature.toByteList(),
+      apiSignature: apiSignature,
       augmentations: augmentations.toFixedList(),
       exports: exports.toFixedList(),
       imports: imports.toFixedList(),
@@ -1183,7 +1192,6 @@ class FileStateTestView {
 
 /// Information about known file system state.
 class FileSystemState {
-  final PerformanceLog _logger;
   final ResourceProvider resourceProvider;
   final String contextName;
   final ByteStore _byteStore;
@@ -1244,14 +1252,21 @@ class FileSystemState {
   /// Used for looking up options to associate with created file states.
   final AnalysisOptionsMap _analysisOptionsMap;
 
+  /// The default performance for [_newFile].
+  ///
+  /// [_newFile] does expensive work, so it is important to see which
+  /// operations it does, and how long they take. But it can be reached
+  /// through getters, which we would like to keep getters. So, instead we
+  /// store here the instance to attach [_newFile] operations.
+  OperationPerformanceImpl? newFileOperationPerformance;
+
   /// We cache results of parsing [FileState]s because they might be useful
   /// in the process of a single analysis operation. But after that, even
   /// if these results are still valid, they are often never used again. So,
   /// currently we clear the cache after each operation.
   ParsedFileStateCache parsedFileStateCache = ParsedFileStateCache();
 
   FileSystemState(
-    this._logger,
     this._byteStore,
     this.resourceProvider,
     this.contextName,
@@ -1577,6 +1592,7 @@ class FileSystemState {
     knownFiles.add(file);
     fileStamp++;
 
+    performance ??= newFileOperationPerformance;
     performance ??= OperationPerformanceImpl('<root>');
     performance.run('fileState.refresh', (performance) {
       file.refresh(

pkg/analyzer/lib/src/dart/analysis/library_context.dart

@@ -285,7 +285,14 @@ class LibraryContext {
     }
 
     await logger.runAsync('Prepare linked bundles', () async {
-      var libraryCycle = targetLibrary.libraryCycle;
+      var libraryCycle = performance.run('libraryCycle', (performance) {
+        fileSystemState.newFileOperationPerformance = performance;
+        try {
+          return targetLibrary.libraryCycle;
+        } finally {
+          fileSystemState.newFileOperationPerformance = null;
+        }
+      });
       await loadBundle(libraryCycle);
       logger.writeln(
         '[librariesTotal: $librariesTotal]'

pkg/analyzer/lib/src/dart/micro/resolve_file.dart

@@ -736,7 +736,6 @@ class FileResolver {
       );
 
       fsState = FileSystemState(
-        logger,
         byteStore,
         resourceProvider,
         'contextName',

pkg/analyzer/lib/src/summary2/library_builder.dart

@@ -1276,21 +1276,24 @@ class LibraryBuilder with MacroApplicationsContainer {
     }
   }
 
-  static void build(
-    Linker linker,
-    LibraryFileKind inputLibrary,
-    MacroResultInput? inputMacroResult,
-  ) {
+  static void build({
+    required Linker linker,
+    required LibraryFileKind inputLibrary,
+    required MacroResultInput? inputMacroResult,
+    required OperationPerformanceImpl performance,
+  }) {
     var elementFactory = linker.elementFactory;
     var rootReference = linker.rootReference;
 
     var libraryFile = inputLibrary.file;
     var libraryUriStr = libraryFile.uriStr;
     var libraryReference = rootReference.getChild(libraryUriStr);
 
-    var libraryUnitNode = libraryFile.parse(
-      performance: OperationPerformanceImpl('<root>'),
-    );
+    var libraryUnitNode = performance.run('libraryFile', (performance) {
+      return libraryFile.parse(
+        performance: performance,
+      );
+    });
 
     var name = '';
     var nameOffset = -1;

pkg/analyzer/lib/src/summary2/link.dart

@@ -107,16 +107,29 @@ class Linker {
     required List<LibraryFileKind> inputLibraries,
     required Map<LibraryFileKind, MacroResultInput> inputMacroResults,
   }) async {
-    for (var inputLibrary in inputLibraries) {
-      var inputMacroResult = inputMacroResults[inputLibrary];
-      LibraryBuilder.build(this, inputLibrary, inputMacroResult);
-    }
+    performance.run('LibraryBuilder.build', (performance) {
+      for (var inputLibrary in inputLibraries) {
+        var inputMacroResult = inputMacroResults[inputLibrary];
+        LibraryBuilder.build(
+          linker: this,
+          inputLibrary: inputLibrary,
+          inputMacroResult: inputMacroResult,
+          performance: performance,
+        );
+      }
+    });
 
-    await _buildOutlines(
-      performance: performance,
-    );
+    await performance.runAsync('buildOutlines', (performance) async {
+      await _buildOutlines(
+        performance: performance,
+      );
+    });
 
-    _writeLibraries();
+    performance.run('writeLibraries', (performance) {
+      _writeLibraries(
+        performance: performance,
+      );
+    });
   }
 
   void _buildClassSyntheticConstructors() {
@@ -462,7 +475,9 @@ class Linker {
     }
   }
 
-  void _writeLibraries() {
+  void _writeLibraries({
+    required OperationPerformanceImpl performance,
+  }) {
     var bundleWriter = BundleWriter(
       elementFactory.dynamicRef,
     );
@@ -473,6 +488,8 @@ class Linker {
 
     var writeWriterResult = bundleWriter.finish();
     resolutionBytes = writeWriterResult.resolutionBytes;
+
+    performance.getDataInt('length').add(resolutionBytes.length);
   }
 }
 

pkg/analyzer/test/src/dart/analysis/file_state_test.dart

@@ -5833,7 +5833,6 @@ class FileSystemStateTest with ResourceProviderMixin {
       packages: Packages.empty,
     );
     fileSystemState = FileSystemState(
-      logger,
       byteStore,
       resourceProvider,
       'contextName',