Skip to content

Commit c8a782f

Browse files
mkustermannCommit Queue
authored and
Commit Queue
committed
[vm] Ensure the standalone embedder (aka dart) passes --link_natives_lazily in AppJIT
The `gen_snapshot` binary passes `--link_natives_lazily` if it generates AppJIT/AOT snapshots (see `runtime/bin/gen_snapshot.cc`) => The `dart` binary should do so as well. TEST=ci Change-Id: I88d69f73a38cb23d4f7482739e2e0fda3c65ecef Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330760 Commit-Queue: Martin Kustermann <[email protected]> Reviewed-by: Daco Harkes <[email protected]>
1 parent e4bb5b6 commit c8a782f

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

runtime/bin/main_impl.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1297,6 +1297,9 @@ void main(int argc, char** argv) {
12971297
// so generated code should not depend on the CPU features
12981298
// of the system where snapshot was generated.
12991299
vm_options.AddArgument("--target-unknown-cpu");
1300+
#if !defined(TARGET_ARCH_IA32)
1301+
vm_options.AddArgument("--link_natives_lazily");
1302+
#endif
13001303
}
13011304
// If we need to write an app-jit snapshot or a depfile, then add an exit
13021305
// hook that writes the snapshot and/or depfile as appropriate.

0 commit comments

Comments
 (0)