Extension type. Fix for accessing constants from extension type, when import prefixed.

Change-Id: Ia3cdd7045276ea903f356b7e7c47a702ad4e39cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362064
Reviewed-by: Kallen Tu <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/CHANGELOG.md

@@ -17,6 +17,7 @@
 * Support new meta annotation: `@mustBeConst`.
 * Support new meta TargetKinds: `constructor`, `directive`, `enumValue`, and
   `typeParameter`.
+* Fix for accessing constants from extension type, when import prefixed.
 
 ## 6.4.1
 * Patch for crash in ffi_verifier.

pkg/analyzer/lib/src/dart/constant/evaluation.dart

@@ -1641,6 +1641,12 @@ class ConstantVisitor extends UnifyingAstVisitor<Constant> {
   Constant? _evaluatePropertyAccess(DartObjectImpl targetResult,
       SimpleIdentifier identifier, AstNode errorNode) {
     var propertyElement = identifier.staticElement;
+    if (propertyElement is PropertyAccessorElement &&
+        propertyElement.isGetter &&
+        propertyElement.isStatic) {
+      return null;
+    }
+
     var propertyContainer = propertyElement?.enclosingElement;
     switch (propertyContainer) {
       case ExtensionElement():

pkg/analyzer/test/src/dart/constant/evaluation_test.dart

@@ -4277,6 +4277,26 @@ String a
 ''');
   }
 
+  test_visitPropertyAccess_constant_extensionType_prefixed() async {
+    newFile('$testPackageLibPath/a.dart', r'''
+extension type const E(int it) {
+  static const v = 42;
+}
+''');
+
+    await assertNoErrorsInCode('''
+import 'a.dart' as prefix;
+
+const x = prefix.E.v;
+''');
+
+    final result = _topLevelVar('x');
+    assertDartObjectText(result, '''
+int 42
+  variable: self::@variable::x
+''');
+  }
+
   test_visitPropertyAccess_length_extension() async {
     await assertErrorsInCode('''
 extension ExtObject on Object {