[vm/ffi] Fix high memory addresses on 32 bit

Issue: #38789

Change-Id: I3227b77c4953dac6aa8b42326539f565eb28ea84
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,app-kernel-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-dartkb-linux-debug-simarm64-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-dartkb-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-mac-debug-simdbc64-try,vm-kernel-precomp-android-release-arm_x64-try,vm-kernel-reload-mac-release-simdbc64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-precomp-mac-release-simarm_x64-try,dart-sdk-linux-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121125
Reviewed-by: Martin Kustermann <[email protected]>
Commit-Queue: Daco Harkes <[email protected]>

Author: dcharkes

runtime/vm/compiler/backend/il.h

@@ -7992,8 +7992,10 @@ class IntConverterInstr : public TemplateDefinition<1, NoThrow, Pure> {
            from == kUnboxedInt32 || from == kUntagged);
     ASSERT(to == kUnboxedInt64 || to == kUnboxedUint32 || to == kUnboxedInt32 ||
            to == kUntagged);
-    ASSERT(from != kUntagged || to == kUnboxedIntPtr);
-    ASSERT(to != kUntagged || from == kUnboxedIntPtr);
+    ASSERT(from != kUntagged ||
+           (to == kUnboxedIntPtr || to == kUnboxedFfiIntPtr));
+    ASSERT(to != kUntagged ||
+           (from == kUnboxedIntPtr || from == kUnboxedFfiIntPtr));
     SetInputAt(0, value);
   }
 

runtime/vm/compiler/backend/il_arm.cc

@@ -6864,8 +6864,10 @@ LocationSummary* IntConverterInstr::MakeLocationSummary(Zone* zone,
   LocationSummary* summary = new (zone)
       LocationSummary(zone, kNumInputs, kNumTemps, LocationSummary::kNoCall);
   if (from() == kUntagged || to() == kUntagged) {
-    ASSERT((from() == kUntagged && to() == kUnboxedIntPtr) ||
-           (from() == kUnboxedIntPtr && to() == kUntagged));
+    ASSERT((from() == kUntagged && to() == kUnboxedInt32) ||
+           (from() == kUntagged && to() == kUnboxedUint32) ||
+           (from() == kUnboxedInt32 && to() == kUntagged) ||
+           (from() == kUnboxedUint32 && to() == kUntagged));
     ASSERT(!CanDeoptimize());
     summary->set_in(0, Location::RequiresRegister());
     summary->set_out(0, Location::SameAsFirstInput());

runtime/vm/compiler/backend/il_ia32.cc

@@ -198,7 +198,7 @@ void NativeReturnInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   __ popl(EBX);
 
 #if defined(TARGET_OS_FUCHSIA)
-  UNREACHABLE(); // Fuchsia does not allow dart:ffi.
+  UNREACHABLE();  // Fuchsia does not allow dart:ffi.
 #elif defined(USING_SHADOW_CALL_STACK)
 #error Unimplemented
 #endif
@@ -1037,7 +1037,7 @@ void NativeEntryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   __ pushl(EAX);
 
 #if defined(TARGET_OS_FUCHSIA)
-  UNREACHABLE(); // Fuchsia does not allow dart:ffi.
+  UNREACHABLE();  // Fuchsia does not allow dart:ffi.
 #elif defined(USING_SHADOW_CALL_STACK)
 #error Unimplemented
 #endif
@@ -6123,8 +6123,10 @@ LocationSummary* IntConverterInstr::MakeLocationSummary(Zone* zone,
       LocationSummary(zone, kNumInputs, kNumTemps, LocationSummary::kNoCall);
 
   if (from() == kUntagged || to() == kUntagged) {
-    ASSERT((from() == kUntagged && to() == kUnboxedIntPtr) ||
-           (from() == kUnboxedIntPtr && to() == kUntagged));
+    ASSERT((from() == kUntagged && to() == kUnboxedInt32) ||
+           (from() == kUntagged && to() == kUnboxedUint32) ||
+           (from() == kUnboxedInt32 && to() == kUntagged) ||
+           (from() == kUnboxedUint32 && to() == kUntagged));
     ASSERT(!CanDeoptimize());
     summary->set_in(0, Location::RequiresRegister());
     summary->set_out(0, Location::SameAsFirstInput());
@@ -6153,8 +6155,10 @@ LocationSummary* IntConverterInstr::MakeLocationSummary(Zone* zone,
 
 void IntConverterInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   const bool is_nop_conversion =
-      (from() == kUntagged && to() == kUnboxedIntPtr) ||
-      (from() == kUnboxedIntPtr && to() == kUntagged);
+      (from() == kUntagged && to() == kUnboxedInt32) ||
+      (from() == kUntagged && to() == kUnboxedUint32) ||
+      (from() == kUnboxedInt32 && to() == kUntagged) ||
+      (from() == kUnboxedUint32 && to() == kUntagged);
   if (is_nop_conversion) {
     ASSERT(locs()->in(0).reg() == locs()->out(0).reg());
     return;

runtime/vm/compiler/frontend/kernel_to_il.cc

@@ -1077,7 +1077,7 @@ FlowGraph* FlowGraphBuilder::BuildGraphOfRecognizedMethod(
       body += CheckNullOptimized(TokenPosition::kNoSource,
                                  String::ZoneHandle(Z, function.name()));
       body += LoadNativeField(Slot::Pointer_c_memory_address());
-      body += UnboxTruncate(kUnboxedIntPtr);  // Truncating, so signed is ok.
+      body += UnboxTruncate(kUnboxedFfiIntPtr);
       body += ConvertIntptrToUntagged();      // Requires signed intptr.
       body += IntConstant(0);                 // Index.
       body += LoadIndexedTypedData(typed_data_cid);
@@ -1196,7 +1196,7 @@ FlowGraph* FlowGraphBuilder::BuildGraphOfRecognizedMethod(
       body += CheckNullOptimized(TokenPosition::kNoSource,
                                  String::ZoneHandle(Z, function.name()));
       body += LoadNativeField(Slot::Pointer_c_memory_address());
-      body += UnboxTruncate(kUnboxedIntPtr);  // Truncating, so signed is ok.
+      body += UnboxTruncate(kUnboxedFfiIntPtr);
       body += ConvertIntptrToUntagged();      // Requires signed intptr.
       body += IntConstant(0);                 // Index.
       body += LoadLocal(arg_value);           // Value.
@@ -1231,6 +1231,8 @@ FlowGraph* FlowGraphBuilder::BuildGraphOfRecognizedMethod(
       body += LoadLocal(parsed_function_->RawParameterVariable(0));  // Address.
       body += CheckNullOptimized(TokenPosition::kNoSource,
                                  String::ZoneHandle(Z, function.name()));
+      // Truncate to 32 bits on 32 bit architecture.
+      body += UnboxTruncate(kUnboxedFfiIntPtr);
       body += StoreInstanceField(TokenPosition::kNoSource,
                                  Slot::Pointer_c_memory_address());
     } break;

tests/ffi/data_test.dart

@@ -52,6 +52,7 @@ void main() {
   testSizeOfNativeFunction();
   testSizeOfNativeType();
   testDynamicInvocation();
+  testMemoryAddressTruncation();
 }
 
 void testPointerBasic() {
@@ -506,3 +507,17 @@ void testDynamicInvocation() {
   final Pointer<Int16> p2 = p.cast<Int16>();
   free(p);
 }
+
+void testMemoryAddressTruncation() {
+  const int kIgnoreBytesPositive = 0x1122334400000000;
+  const int kIgnoreBytesNegative = 0xffddccbb00000000;
+  if (sizeOf<IntPtr>() == 4) {
+    final p1 = Pointer<Int8>.fromAddress(123);
+    final p2 = Pointer<Int8>.fromAddress(123 + kIgnoreBytesPositive);
+    final p3 = Pointer<Int8>.fromAddress(123 + kIgnoreBytesNegative);
+    Expect.equals(p1.address, p2.address);
+    Expect.equals(p1, p2);
+    Expect.equals(p1.address, p3.address);
+    Expect.equals(p1, p3);
+  }
+}