Skip to content

Commit cc0a9c3

Browse files
committed
Fix calls to pthread_join
BUG= [email protected] Review URL: https://codereview.chromium.org/1412343002 .
1 parent f8092a1 commit cc0a9c3

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

runtime/vm/os_thread_android.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,8 @@ ThreadJoinId OSThread::GetCurrentThreadJoinId() {
167167

168168

169169
void OSThread::Join(ThreadJoinId id) {
170-
ASSERT(pthread_join(id, NULL) == 0);
170+
int result = pthread_join(id, NULL);
171+
ASSERT(result == 0);
171172
}
172173

173174

runtime/vm/os_thread_linux.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,8 @@ ThreadJoinId OSThread::GetCurrentThreadJoinId() {
169169

170170

171171
void OSThread::Join(ThreadJoinId id) {
172-
ASSERT(pthread_join(id, NULL) == 0);
172+
int result = pthread_join(id, NULL);
173+
ASSERT(result == 0);
173174
}
174175

175176

runtime/vm/os_thread_macos.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,8 @@ ThreadJoinId OSThread::GetCurrentThreadJoinId() {
161161

162162

163163
void OSThread::Join(ThreadJoinId id) {
164-
ASSERT(pthread_join(id, NULL) == 0);
164+
int result = pthread_join(id, NULL);
165+
ASSERT(result == 0);
165166
}
166167

167168

0 commit comments

Comments
 (0)