[cfe] Report errors in inherited restricted members in enums

Part of #47453

Change-Id: I5f80c3507a0264c4516d42967b148f4dc3fd08ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237684
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>

Author: chloestefantsova

pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart

@@ -2949,6 +2949,38 @@ const MessageCode messageEnumInClass = const MessageCode("EnumInClass",
     problemMessage: r"""Enums can't be declared inside classes.""",
     correctionMessage: r"""Try moving the enum to the top-level.""");
 
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Template<Message Function(String name)> templateEnumInheritsRestricted =
+    const Template<Message Function(String name)>(
+        problemMessageTemplate:
+            r"""An enum can't inherit a member named '#name'.""",
+        withArguments: _withArgumentsEnumInheritsRestricted);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<Message Function(String name)> codeEnumInheritsRestricted =
+    const Code<Message Function(String name)>(
+  "EnumInheritsRestricted",
+);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+Message _withArgumentsEnumInheritsRestricted(String name) {
+  if (name.isEmpty) throw 'No name provided';
+  name = demangleMixinApplicationName(name);
+  return new Message(codeEnumInheritsRestricted,
+      problemMessage: """An enum can't inherit a member named '${name}'.""",
+      arguments: {'name': name});
+}
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<Null> codeEnumInheritsRestrictedMember =
+    messageEnumInheritsRestrictedMember;
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const MessageCode messageEnumInheritsRestrictedMember = const MessageCode(
+    "EnumInheritsRestrictedMember",
+    severity: Severity.context,
+    problemMessage: r"""This is the inherited member""");
+
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Code<Null> codeEnumInstantiation = messageEnumInstantiation;
 

pkg/front_end/lib/src/fasta/source/source_loader.dart

@@ -2134,6 +2134,45 @@ severity: $severity
     }
     ticker.logMs("Checked ${overrideChecks.length} overrides");
 
+    List<Name> restrictedMemberNames = <Name>[
+      new Name("index"),
+      new Name("hashCode"),
+      new Name("=="),
+      new Name("values")
+    ];
+    List<Class?> restrictedMemberDeclarers = <Class?>[
+      (target.underscoreEnumType.declaration as ClassBuilder).cls,
+      coreTypes.objectClass,
+      coreTypes.objectClass,
+      null
+    ];
+    for (SourceClassBuilder classBuilder in sourceClasses) {
+      if (classBuilder.isEnum) {
+        for (int i = 0; i < restrictedMemberNames.length; ++i) {
+          Name name = restrictedMemberNames[i];
+          Class? declarer = restrictedMemberDeclarers[i];
+
+          Member? member = hierarchy.getDispatchTarget(classBuilder.cls, name);
+          if (member?.enclosingClass != declarer &&
+              member?.enclosingClass != classBuilder.cls &&
+              member?.isAbstract == false) {
+            classBuilder.libraryBuilder.addProblem(
+                templateEnumInheritsRestricted.withArguments(name.text),
+                classBuilder.charOffset,
+                classBuilder.name.length,
+                classBuilder.fileUri,
+                context: <LocatedMessage>[
+                  messageEnumInheritsRestrictedMember.withLocation(
+                      member!.fileUri,
+                      member.fileOffset,
+                      member.name.text.length)
+                ]);
+          }
+        }
+      }
+    }
+    ticker.logMs("Checked for restricted members inheritance in enums.");
+
     typeInferenceEngine.finishTopLevelInitializingFormals();
     ticker.logMs("Finished initializing formals");
   }

pkg/front_end/messages.status

@@ -233,6 +233,8 @@ EnumImplementerContainsRestrictedInstanceDeclaration/analyzerCode: Fail
 EnumImplementerContainsRestrictedInstanceDeclaration/example: Fail
 EnumImplementerContainsValuesDeclaration/analyzerCode: Fail
 EnumImplementerContainsValuesDeclaration/example: Fail
+EnumInheritsRestricted/analyzerCode: Fail
+EnumInheritsRestricted/example: Fail
 EnumInstantiation/example: Fail
 EnumNonConstConstructor/analyzerCode: Fail
 EnumNonConstConstructor/example: Fail

pkg/front_end/messages.yaml

@@ -5536,6 +5536,13 @@ EnumContainsValuesDeclaration:
 EnumImplementerContainsValuesDeclaration:
   problemMessage: "'#name' has 'Enum' as a superinterface and can't contain non-static member with name 'values'."
 
+EnumInheritsRestricted:
+  problemMessage: "An enum can't inherit a member named '#name'."
+
+EnumInheritsRestrictedMember:
+  problemMessage: "This is the inherited member"
+  severity: CONTEXT
+
 MacroClassNotDeclaredMacro:
   problemMessage: "Non-abstract class '#name' implements 'Macro' but isn't declared as a macro class."
   correctionMessage: "Try adding the 'macro' class modifier."

pkg/front_end/test/spell_checking_list_common.txt

@@ -744,6 +744,8 @@ declaration's
 declarations
 declare
 declared
+declarer
+declarers
 declares
 declaring
 decode

pkg/front_end/testcases/enhanced_enums/inherited_restricted_members.dart

@@ -0,0 +1,89 @@
+// Copyright (c) 2022, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+class A1 {
+  int get hashCode => 42;
+}
+
+enum E1 with A1 { // Error.
+  element
+}
+
+class A2 {
+  int get values => 42;
+}
+
+enum E2 with A2 { // Error.
+  element
+}
+
+class A3 {
+  int get index => 42;
+}
+
+enum E3 with A3 { // Error.
+  element
+}
+
+class A4 {
+  bool operator==(Object other) => true;
+}
+
+enum E4 with A4 { // Error.
+  element
+}
+
+mixin M5 {
+  int get hashCode => 42;
+}
+
+enum E5 with M5 { // Error.
+  element
+}
+
+mixin M6 {
+  int get values => 42;
+}
+
+enum E6 with M6 { // Error.
+  element
+}
+
+mixin M7 {
+  int get index => 42;
+}
+
+enum E7 with M7 { // Error.
+  element
+}
+
+mixin M8 {
+  bool operator==(Object other) => true;
+}
+
+enum E8 with M8 { // Error.
+  element
+}
+
+abstract class A9 {
+  int get index;
+  int get hashCode;
+  bool operator==(Object other);
+}
+
+enum E9 with A9 { // Ok.
+  element
+}
+
+mixin M10 {
+  int get index;
+  int get hashCode;
+  bool operator==(Object other);
+}
+
+enum E10 with M10 { // Ok.
+  element
+}
+
+main() {}