[cfe] Allow extension members with names as Object static members

Closes #48834

Change-Id: If756cf5b3416b2ed9953fe577b8b2e9490a70dd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241603
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>

Author: chloestefantsova

pkg/front_end/lib/src/fasta/source/source_extension_builder.dart

@@ -106,7 +106,8 @@ class SourceExtensionBuilder extends ExtensionBuilderImpl {
         Builder? objectGetter = objectClassBuilder.lookupLocalMember(name);
         Builder? objectSetter =
             objectClassBuilder.lookupLocalMember(name, setter: true);
-        if (objectGetter != null || objectSetter != null) {
+        if (objectGetter != null && !objectGetter.isStatic ||
+            objectSetter != null && !objectSetter.isStatic) {
           addProblem(
               templateExtensionMemberConflictsWithObjectMember
                   .withArguments(name),

pkg/front_end/testcases/general/issue48834.dart

@@ -0,0 +1,18 @@
+// Copyright (c) 2022, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+extension HashAll on Iterable {
+  int hashAll() => 0;
+}
+
+extension HashAllList on List {
+  int hashAll() => 1;
+}
+
+void main() {
+  List l = [];
+  Iterable i = [];
+  print(l.hashAll());
+  print(i.hashAll());
+}

pkg/front_end/testcases/general/issue48834.dart.textual_outline.expect

@@ -0,0 +1,9 @@
+extension HashAll on Iterable {
+  int hashAll() => 0;
+}
+
+extension HashAllList on List {
+  int hashAll() => 1;
+}
+
+void main() {}

pkg/front_end/testcases/general/issue48834.dart.textual_outline_modelled.expect

@@ -0,0 +1,9 @@
+extension HashAll on Iterable {
+  int hashAll() => 0;
+}
+
+extension HashAllList on List {
+  int hashAll() => 1;
+}
+
+void main() {}

pkg/front_end/testcases/general/issue48834.dart.weak.expect

@@ -0,0 +1,26 @@
+library /*isNonNullableByDefault*/;
+import self as self;
+import "dart:core" as core;
+
+extension HashAll on core::Iterable<dynamic> {
+  method hashAll = self::HashAll|hashAll;
+  tearoff hashAll = self::HashAll|get#hashAll;
+}
+extension HashAllList on core::List<dynamic> {
+  method hashAll = self::HashAllList|hashAll;
+  tearoff hashAll = self::HashAllList|get#hashAll;
+}
+static method HashAll|hashAll(lowered final core::Iterable<dynamic> #this) → core::int
+  return 0;
+static method HashAll|get#hashAll(lowered final core::Iterable<dynamic> #this) → () → core::int
+  return () → core::int => self::HashAll|hashAll(#this);
+static method HashAllList|hashAll(lowered final core::List<dynamic> #this) → core::int
+  return 1;
+static method HashAllList|get#hashAll(lowered final core::List<dynamic> #this) → () → core::int
+  return () → core::int => self::HashAllList|hashAll(#this);
+static method main() → void {
+  core::List<dynamic> l = <dynamic>[];
+  core::Iterable<dynamic> i = <dynamic>[];
+  core::print(self::HashAllList|hashAll(l));
+  core::print(self::HashAll|hashAll(i));
+}

pkg/front_end/testcases/general/issue48834.dart.weak.modular.expect

@@ -0,0 +1,26 @@
+library /*isNonNullableByDefault*/;
+import self as self;
+import "dart:core" as core;
+
+extension HashAll on core::Iterable<dynamic> {
+  method hashAll = self::HashAll|hashAll;
+  tearoff hashAll = self::HashAll|get#hashAll;
+}
+extension HashAllList on core::List<dynamic> {
+  method hashAll = self::HashAllList|hashAll;
+  tearoff hashAll = self::HashAllList|get#hashAll;
+}
+static method HashAll|hashAll(lowered final core::Iterable<dynamic> #this) → core::int
+  return 0;
+static method HashAll|get#hashAll(lowered final core::Iterable<dynamic> #this) → () → core::int
+  return () → core::int => self::HashAll|hashAll(#this);
+static method HashAllList|hashAll(lowered final core::List<dynamic> #this) → core::int
+  return 1;
+static method HashAllList|get#hashAll(lowered final core::List<dynamic> #this) → () → core::int
+  return () → core::int => self::HashAllList|hashAll(#this);
+static method main() → void {
+  core::List<dynamic> l = <dynamic>[];
+  core::Iterable<dynamic> i = <dynamic>[];
+  core::print(self::HashAllList|hashAll(l));
+  core::print(self::HashAll|hashAll(i));
+}

pkg/front_end/testcases/general/issue48834.dart.weak.outline.expect

@@ -0,0 +1,22 @@
+library /*isNonNullableByDefault*/;
+import self as self;
+import "dart:core" as core;
+
+extension HashAll on core::Iterable<dynamic> {
+  method hashAll = self::HashAll|hashAll;
+  tearoff hashAll = self::HashAll|get#hashAll;
+}
+extension HashAllList on core::List<dynamic> {
+  method hashAll = self::HashAllList|hashAll;
+  tearoff hashAll = self::HashAllList|get#hashAll;
+}
+static method HashAll|hashAll(lowered final core::Iterable<dynamic> #this) → core::int
+  ;
+static method HashAll|get#hashAll(lowered final core::Iterable<dynamic> #this) → () → core::int
+  return () → core::int => self::HashAll|hashAll(#this);
+static method HashAllList|hashAll(lowered final core::List<dynamic> #this) → core::int
+  ;
+static method HashAllList|get#hashAll(lowered final core::List<dynamic> #this) → () → core::int
+  return () → core::int => self::HashAllList|hashAll(#this);
+static method main() → void
+  ;

pkg/front_end/testcases/general/issue48834.dart.weak.transformed.expect

@@ -0,0 +1,26 @@
+library /*isNonNullableByDefault*/;
+import self as self;
+import "dart:core" as core;
+
+extension HashAll on core::Iterable<dynamic> {
+  method hashAll = self::HashAll|hashAll;
+  tearoff hashAll = self::HashAll|get#hashAll;
+}
+extension HashAllList on core::List<dynamic> {
+  method hashAll = self::HashAllList|hashAll;
+  tearoff hashAll = self::HashAllList|get#hashAll;
+}
+static method HashAll|hashAll(lowered final core::Iterable<dynamic> #this) → core::int
+  return 0;
+static method HashAll|get#hashAll(lowered final core::Iterable<dynamic> #this) → () → core::int
+  return () → core::int => self::HashAll|hashAll(#this);
+static method HashAllList|hashAll(lowered final core::List<dynamic> #this) → core::int
+  return 1;
+static method HashAllList|get#hashAll(lowered final core::List<dynamic> #this) → () → core::int
+  return () → core::int => self::HashAllList|hashAll(#this);
+static method main() → void {
+  core::List<dynamic> l = core::_GrowableList::•<dynamic>(0);
+  core::Iterable<dynamic> i = core::_GrowableList::•<dynamic>(0);
+  core::print(self::HashAllList|hashAll(l));
+  core::print(self::HashAll|hashAll(i));
+}