Skip to content

Commit e7bd696

Browse files
mkustermannCommit Queue
authored and
Commit Queue
committed
[vm] Update CPU register comments on runtime/vm/constants_<arch>.h
TEST=ci Change-Id: Ibc2225314a18818ac14c8b3047c369017e524210 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273140 Commit-Queue: Martin Kustermann <[email protected]> Reviewed-by: Tess Strickland <[email protected]>
1 parent 49f998d commit e7bd696

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

runtime/vm/constants_arm.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,12 @@ enum Register {
8989
R3 = 3,
9090
R4 = 4,
9191
R5 = 5, // PP
92-
R6 = 6, // CODE
93-
R7 = 7, // iOS FP
92+
R6 = 6, // CODE_REG
93+
R7 = 7, // FP on iOS, DISPATCH_TABLE_REG on non-iOS (AOT only)
9494
R8 = 8,
9595
R9 = 9,
9696
R10 = 10, // THR
97-
R11 = 11, // Linux/Android/Windows FP
97+
R11 = 11, // FP on non-iOS, DISPATCH_TABLE_REG on iOS (AOT only)
9898
R12 = 12, // IP aka TMP
9999
R13 = 13, // SP
100100
R14 = 14, // LR

runtime/vm/constants_arm64.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,10 @@ enum Register {
5353
R18 = 18, // reserved on iOS, shadow call stack on Fuchsia, TEB on Windows.
5454
R19 = 19,
5555
R20 = 20,
56-
R21 = 21, // DISPATCH_TABLE_REG
56+
R21 = 21, // DISPATCH_TABLE_REG (AOT only)
5757
R22 = 22, // NULL_REG
5858
R23 = 23,
59-
R24 = 24,
59+
R24 = 24, // CODE_REG
6060
R25 = 25,
6161
R26 = 26, // THR
6262
R27 = 27, // PP

0 commit comments

Comments
 (0)