[dart2js] Fix as-check type registration.

We would expect failing as checks to throw in all modes (unless --omit-as-casts is provided). However, the new test program fails in production mode. This is because we are not registering the type usage of the function's type parameter. This leads us to drop the as check completely later on.

We should be doing subtype checks with nullability if we want to consider an as test omitted.

Golem patch results: https://golem.corp.goog/Comparison?repository=dart#targetA%3Ddart2js%3BmachineTypeA%3Dlinux-x64%3BrevisionA%3D107840%3BpatchA%3Dnatebiggs--dart2js--Fix-as-check-type-registration.-7%3BtargetB%3Ddart2js%3BmachineTypeB%3Dlinux-x64%3BrevisionB%3D107839%3BpatchB%3DNone

Fixed: #54419
Change-Id: If93f78a939a690f05f5398c1a5ca971df1fc9243
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/343821
Reviewed-by: Mayank Patke <[email protected]>
Reviewed-by: Stephen Adams <[email protected]>
Commit-Queue: Nate Biggs <[email protected]>

Author: natebiggs

pkg/compiler/lib/src/ir/impact_data.dart

@@ -222,8 +222,8 @@ class ImpactBuilder extends StaticTypeVisitor implements ImpactRegistry {
   void handleAsExpression(ir.AsExpression node, ir.DartType operandType,
       {bool? isCalculatedTypeSubtype}) {
     if (isCalculatedTypeSubtype ??
-        typeEnvironment.isSubtypeOf(operandType, node.type,
-            ir.SubtypeCheckMode.ignoringNullabilities)) {
+        typeEnvironment.isSubtypeOf(
+            operandType, node.type, ir.SubtypeCheckMode.withNullabilities)) {
       // Skip unneeded casts.
       return;
     }

pkg/compiler/lib/src/ir/static_type.dart

@@ -1320,7 +1320,7 @@ abstract class StaticTypeVisitor extends StaticTypeBase {
     // Check if the calculated operandType is a subtype of the type specified
     // in the `as` expression.
     final isCalculatedTypeSubtype = typeEnvironment.isSubtypeOf(
-        operandType, node.type, ir.SubtypeCheckMode.ignoringNullabilities);
+        operandType, node.type, ir.SubtypeCheckMode.withNullabilities);
     if (!isCalculatedTypeSubtype &&
         operand is ir.VariableGet &&
         !_invalidatedVariables.contains(operand.variable)) {

pkg/compiler/test/closure/data/generic.dart

@@ -56,12 +56,10 @@ class Class1<T> {
     }
 
     var local2 =
-        /*prod.hasThis*/
-        /*spec.fields=[S,this],free=[S,this],hasThis*/
+        /*fields=[S,this],free=[S,this],hasThis*/
         (o) {
       return
-          /*prod.hasThis*/
-          /*spec.fields=[S,this],free=[S,this],hasThis*/
+          /*fields=[S,this],free=[S,this],hasThis*/
           () => Map<T, S>();
     };
     return local2(local<double>());

pkg/compiler/test/closure/data/list_literal_untested_class.dart

@@ -9,8 +9,7 @@ class A<T> {
   /*member: A.method:hasThis*/
   @pragma('dart2js:noInline')
   method() {
-    /*spec.fields=[this],free=[this],hasThis*/
-    /*prod.hasThis*/
+    /*fields=[this],free=[this],hasThis*/
     dynamic local() => <T>[];
     return local;
   }

pkg/compiler/test/closure/data/list_literal_untested_method.dart

@@ -6,7 +6,7 @@ import 'package:expect/expect.dart';
 
 @pragma('dart2js:noInline')
 method<T>() {
-  /*spec.fields=[T],free=[T]*/
+  /*fields=[T],free=[T]*/
   dynamic local() => <T>[];
   return local;
 }

pkg/compiler/test/closure/data/map_literal_untested_class.dart

@@ -9,8 +9,7 @@ class A<T> {
   /*member: A.method:hasThis*/
   @pragma('dart2js:noInline')
   method() {
-    /*spec.fields=[this],free=[this],hasThis*/
-    /*prod.hasThis*/
+    /*fields=[this],free=[this],hasThis*/
     dynamic local() => <T, int>{};
     return local;
   }

pkg/compiler/test/closure/data/map_literal_untested_method.dart

@@ -6,7 +6,7 @@ import 'package:expect/expect.dart';
 
 @pragma('dart2js:noInline')
 method<T>() {
-  /*spec.fields=[T],free=[T]*/
+  /*fields=[T],free=[T]*/
   dynamic local() => <T, int>{};
   return local;
 }

pkg/compiler/test/codegen/data/array_add.dart

@@ -12,7 +12,7 @@
   return t1;
 }*/
 /*prod.member: test1:function() {
-  var t1 = [];
+  var t1 = A._setArrayType([], type$.JSArray_int);
   t1.push(1);
   return t1;
 }*/

pkg/compiler/test/codegen/literal_list_test.dart

@@ -18,12 +18,18 @@ foo() {
 main() {
   runTest() async {
     await compile(TEST_ONE, entry: 'foo', check: (String generated) {
-      Expect.isTrue(generated.contains('print([1, 2]);'),
-          "Code pattern 'print([1, 2]);' not found in\n$generated");
-      Expect.isTrue(generated.contains('print([3]);'),
-          "Code pattern 'print([3]);' not found in\n$generated");
-      Expect.isTrue(generated.contains('print([4, 5]);'),
-          "Code pattern 'print([4, 5]);' not found in\n$generated");
+      Expect.isTrue(
+          generated.contains('A.print(A._setArrayType([1, 2], t1));'),
+          "Code pattern 'A.print(A._setArrayType([1, 2], t1));' "
+          "not found in\n$generated");
+      Expect.isTrue(
+          generated.contains('A.print(A._setArrayType([3], t1));'),
+          "Code pattern 'A.print(A._setArrayType([3], t1));' "
+          "not found in\n$generated");
+      Expect.isTrue(
+          generated.contains('A.print(A._setArrayType([4, 5], t1));'),
+          "Code pattern 'A.print(A._setArrayType([4, 5], t1));' "
+          "not found in\n$generated");
     });
   }
 

pkg/compiler/test/rti/data/async_foreach.dart

@@ -7,7 +7,7 @@
 import 'package:compiler/src/util/testing.dart';
 
 /*spec.class: Class:explicit=[Class.T*],implicit=[Class.T],needsArgs,test*/
-/*prod.class: Class:needsArgs*/
+/*prod.class: Class:implicit=[Class.T],needsArgs,test*/
 class Class<T> {
   method() {
     var list = <T>[];