Skip to content

Commit f5ec9b0

Browse files
committed
This CL changes some status comments, but also points out an issue.
The point is that #32782 requests a fix such that `typedef F1 = void Function(int)` and `typedef void F2(int)` satisfy that `F1 == F2` evaluates to true. This is marked 'p3-low' for the common front end but 'p1-high' for DDC. It seems likely to me that this could create the situation where code is developed using DDC, is working, and then fails upon deployment using the vm. Also, there is a single case where `dart2js` fails in the associated `type_alias_equality_test.dart`, so deployment on the web would also fail upon deployment, though only in some of the cases. However, with some input from Aske I concluded that the situation might have arisen because there _is_ no work to do for this in the common front end, because it will be handled by the backend (which also explains why `dart2js` has it almost right). This CL is just introducing a tiny change: It changes the issue indicated for all VM related failures in said test to point to #32783, which is presumably the right issue for backend work. Apart from that, I've added you, the reviewers, in order to make sure that the relevant people get this heads up. We may then decide to land this CL, change the priority on #31359, do nothing, or whatever turns out to be the right response. ;-) Change-Id: I92672547d7fe795e877604c0da1e0e4579e4e04a Reviewed-on: https://dart-review.googlesource.com/74403 Reviewed-by: Jenny Messerly <[email protected]>
1 parent a16c7d8 commit f5ec9b0

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

tests/language_2/language_2_kernel.status

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,9 @@ string_split_test: CompileTimeError
148148
string_supertype_checked_test: CompileTimeError
149149
super_bound_closure_test/none: CompileTimeError
150150
super_test: RuntimeError
151-
type_alias_equality_test/02: RuntimeError
152-
type_alias_equality_test/03: RuntimeError
153-
type_alias_equality_test/04: RuntimeError
151+
type_alias_equality_test/02: RuntimeError # Issue 32783
152+
type_alias_equality_test/03: RuntimeError # Issue 32783
153+
type_alias_equality_test/04: RuntimeError # Issue 32783
154154
type_error_test: RuntimeError
155155
type_literal_test: RuntimeError
156156
type_promotion_functions_test/02: CompileTimeError
@@ -424,7 +424,7 @@ compile_time_constant_o_test/02: Pass
424424
const_dynamic_type_literal_test/02: Pass
425425
map_literal3_test/01: Pass
426426
map_literal3_test/02: Pass
427-
type_alias_equality_test/02: RuntimeError # Issue 31359
427+
type_alias_equality_test/02: RuntimeError # Issue 32783
428428
vm/bool_check_stack_traces_test/01: RuntimeError # No support for line numbers in stacktraces
429429
vm/bool_check_stack_traces_test/none: RuntimeError # No support for line numbers in stacktraces
430430
vm/causal_async_exception_stack2_test: RuntimeError # No support for line numbers in stacktraces
@@ -452,9 +452,9 @@ vm/type_vm_test/35: MissingRuntimeError
452452
vm/type_vm_test/36: MissingRuntimeError
453453

454454
[ $compiler == dartkp && $runtime == dart_precompiled ]
455-
type_alias_equality_test/02: RuntimeError # Issue 31359
456-
type_alias_equality_test/03: RuntimeError # Issue 31359
457-
type_alias_equality_test/04: RuntimeError # Issue 31359
455+
type_alias_equality_test/02: RuntimeError # Issue 32783
456+
type_alias_equality_test/03: RuntimeError # Issue 32783
457+
type_alias_equality_test/04: RuntimeError # Issue 32783
458458
vm/bool_check_stack_traces_test/01: RuntimeError # Issue 33584
459459
vm/bool_check_stack_traces_test/02: RuntimeError # Issue 33584
460460

@@ -2112,9 +2112,9 @@ redirecting_factory_reflection_test: RuntimeError
21122112

21132113
[ ($compiler == app_jitk || $compiler == dartk || $compiler == dartkp) && ($runtime == dart_precompiled || $runtime == vm) ]
21142114
covariant_subtyping_with_mixin_test: RuntimeError # Issue 34321
2115-
type_alias_equality_test/02: RuntimeError # Issue 31359
2116-
type_alias_equality_test/03: RuntimeError # Issue 31359
2117-
type_alias_equality_test/04: RuntimeError # Issue 31359
2115+
type_alias_equality_test/02: RuntimeError # Issue 32783
2116+
type_alias_equality_test/03: RuntimeError # Issue 32783
2117+
type_alias_equality_test/04: RuntimeError # Issue 32783
21182118

21192119
[ ($compiler == dartk || $compiler == dartkb) && ($hot_reload || $hot_reload_rollback) ]
21202120
async_star_test/01: Skip # Timeout

0 commit comments

Comments
 (0)