Skip to content

Commit fca91e4

Browse files
munificentcommit-bot@chromium.org
authored andcommitted
Migrate css_selector_test off unittest.
This test was actually totally broken. It called useHtmlIndividualConfiguration(), which tells the test runner to treat each group() as a separate test. But it had no group() calls at all, so the test runner didn't enqueue *anything* for it. It was completely skipped. :-O Change-Id: Ib7b030c94d286f467601ec490308c32fb500c7a8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137291 Commit-Queue: Bob Nystrom <[email protected]> Commit-Queue: Srujan Gaddam <[email protected]> Auto-Submit: Bob Nystrom <[email protected]> Reviewed-by: Srujan Gaddam <[email protected]>
1 parent f304dac commit fca91e4

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

tests/lib_2/html/css_selector_test.dart

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,10 @@
44

55
import 'dart:html';
66

7-
import 'package:unittest/unittest.dart';
8-
import 'package:unittest/html_individual_config.dart';
7+
import 'package:expect/expect.dart';
98
import 'utils.dart';
109

1110
main() {
12-
useHtmlIndividualConfiguration();
13-
1411
final String htmlPayload = "<div>"
1512
"<div>"
1613
"<p class='a'>"
@@ -32,18 +29,20 @@ main() {
3229
para.classes.removeAll(['a', 'b']);
3330

3431
para = document.body.querySelector('p') as ParagraphElement;
35-
expect(para.outerHtml, '<p class=""><span>Test #1</span></p>');
32+
Expect.equals('<p class=""><span>Test #1</span></p>', para.outerHtml);
3633

3734
para = document.body.querySelector('p') as ParagraphElement;
3835
para.classes.addAll(['c']);
3936

4037
para = document.body.querySelector('p') as ParagraphElement;
41-
expect(para.outerHtml, '<p class="c"><span>Test #1</span></p>');
38+
Expect.equals('<p class="c"><span>Test #1</span></p>', para.outerHtml);
4239

4340
var allPara = document.body.querySelectorAll('p');
4441
allPara.classes.removeAll(['b', 'c']);
4542

4643
var checkAllPara = document.body.querySelectorAll('p');
47-
expect(checkAllPara[0].outerHtml, '<p class=""><span>Test #1</span></p>');
48-
expect(checkAllPara[1].outerHtml, '<p class=""><span>Test #2</span></p>');
44+
Expect.equals(
45+
'<p class=""><span>Test #1</span></p>', checkAllPara[0].outerHtml);
46+
Expect.equals(
47+
'<p class=""><span>Test #2</span></p>', checkAllPara[1].outerHtml);
4948
}

0 commit comments

Comments
 (0)