Crash dartium tab with this fancy-sytnax #12316
Comments
|
FWIW this works fine: <ul> |
|
FYI I tried to test this on bleeding_edge editor, but ran into what appears to be a fancy-syntax bug. See https://github.com/dart-lang/fancy-syntax/issues/29 which we'll need to fix before we can confirm if the Dartium issue is fixed. |
|
OK, I changed "break on exceptions: all" to "break on exceptions: uncaught" and I can reproduce the Dartium crash. Specifically, Dartium Version 30.0.1581.0 (214250) |
|
The Fancy Syntax example also reliably crashes Dartium as of 25972 https://github.com/dart-lang/fancy-syntax/blob/master/example/example.html |
|
Bumping to High, I don't think we can release on Monday with this crash. Removed Priority-Unassigned label. |
|
cc @jacob314. |
|
Quick glance it's crashing in mirrors |
|
Stack trace: Also note that this method is called a couple of times successfully before it crashes: cc @iposva-google. |
|
Set owner to @rmacnak-google. |
|
I tried this with the dartium 25983, and it did not crash for me. Thanks for the quick fix! Added Fixed label. |
|
Awesome, thanks for the fix! |
sethladd
added
Type-Defect
P0
Using Dart Editor version 0.6.15_r25822
Consider this code:
<!DOCTYPE html>
<html>
<head>
<title>index</title>
<script src="packages/polymer/boot.js"></script>
</head>
<body>
<template id="tmpl" bind>
<!-- Only works with fancy-syntax -->
<ul>
<template repeat="{{k in addresses.keys}}">
<li>{{addresses[k]}}</li>
</template>
</ul>
<!-- This should work, but doesn't -->
<!-- See https://github.com/dart-lang/fancy-syntax/issues/9 -->
<!--
<template repeat="{{a > 21 ? [1,2,3] : [5,6,7]}}">
<li>{{}}</li>
</template>
-->
</template>
<script type="application/dart" src="index.dart"></script>
</body>
</html>
import 'dart:html';
import 'package:fancy_syntax/syntax.dart';
class Person {
String firstName;
String lastName;
bool signedAgreement;
int age;
Map<String, Address> addresses = new Map<String, Address>();
List<Color> favoriteColors = new List<Color>();
String get fullName => '$firstName $lastName';
Address addressFor(String name) => addresses[name];
}
class Address {
String street;
String city;
Address(this.street, this.city);
}
class Color {
String name;
String hex;
String toString() => '$name is $hex in hex';
}
main() {
Person bob = new Person()
..firstName = 'Bob'
..lastName = 'Smith'
..signedAgreement = true
..age = 42
..favoriteColors.add(new Color()..name="red"..hex="#FF0000")
..favoriteColors.add(new Color()..name="yellow"..hex="#FFFF00")
..addresses['home'] = new Address("main st", "smallville")
..addresses['work'] = new Address('oak way', 'gotham');
TemplateElement template = query('#tmpl');
template.bindingDelegate = new FancySyntax();
template.model = bob;
}
Run that, and I get a crashed Aw Snap tab.
Attachment:
[Screen Shot 2013-08-07 at 11.11.45 PM.png](https://storage.googleapis.com/google-code-attachments/dart/issue-12316/comment-0/Screen Shot 2013-08-07 at 11.11.45 PM.png) (37.19 KB)
The text was updated successfully, but these errors were encountered: