Skip to content

Should not hide the true name of classes at the reflective level #12358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rmacnak-google opened this issue Aug 9, 2013 · 2 comments
Closed

Should not hide the true name of classes at the reflective level #12358

rmacnak-google opened this issue Aug 9, 2013 · 2 comments
Assignees
@rmacnak-google
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-mirrors

Comments

@rmacnak-google
Copy link
Contributor

At the base level we hide the implementation details of integers, strings, etc.

1.runtimeType.toString() == 0xFFFFFFFFFFFFFFFFFF.runtimeType.toString()

But at the reflective level, we should not.

reflect('').type != reflectClass(String)

We are currently hiding their distinct names

reflect('').type.simpleName == reflectClass(String).simpleName

which shouldn't be the case.
@rmacnak-google
Copy link
Contributor Author

Fixed in r28551.

@rmacnak-google
Copy link
Contributor Author

Added Fixed label.

@rmacnak-google rmacnak-google added Type-Defect library-mirrors area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Oct 11, 2013
@rmacnak-google rmacnak-google self-assigned this Oct 11, 2013
@iarkh iarkh mentioned this issue Oct 27, 2018
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmacnak-google rmacnak-google

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-mirrors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevmoo @rmacnak-google