Skip to content

VM: Make Null an ordinary class #12364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rmacnak-google opened this issue Aug 10, 2013 · 5 comments
Closed

VM: Make Null an ordinary class #12364

rmacnak-google opened this issue Aug 10, 2013 · 5 comments
Assignees
@lrhn
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-enhancement A request for a change that isn't a bug

Comments

@rmacnak-google
Copy link
Contributor

Null should either become a public class exported by dart:core, or a private class and renamed _Null.
@lrhn
Copy link
Member

lrhn commented Aug 12, 2013

Why?

Personally, I've always wanted it to be a public class, but I could obviously use a convincing argument for it!

Removed the owner.
Removed Type-Defect, Area-VM labels.
Added Type-Enhancement, Area-Library, NeedsInfo labels.

@rmacnak-google
Copy link
Contributor Author

Marked this as blocking #12382.

@rmacnak-google
Copy link
Contributor Author

null is a class like any other and has a class like any other. Special cases need arguments, not ordinary cases.

Set owner to @rmacnak-google.
Removed Area-Library label.
Added Area-VM, Accepted labels.
Changed the title to: "VM: Make Null an ordinary class".

@lrhn
Copy link
Member

lrhn commented Aug 14, 2013

CL uploaded.

Set owner to @lrhn.

@rmacnak-google
Copy link
Contributor Author

Fixed in r26175 and r26205.

Added Fixed label.

@rmacnak-google rmacnak-google added Type-Enhancement area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Aug 15, 2013
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed priority-unassigned labels Mar 1, 2016
@iarkh iarkh mentioned this issue Oct 27, 2018
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrhn lrhn

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @lrhn @rmacnak-google