-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Use command line flags instead of ENV variables to control VM settings in Dartium #13300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
See related bug: https://code.google.com/p/dart/issues/detail?id=3092 It makes sense to expose some flags (e.g., checked mode) via HTML but keep other internal ones here. |
We should use the same mechanism as V8 to pass flags. Marking as high because we do not want to change this in the future. Set owner to @a-siva. |
V8 uses --js-flags='...' to pass in flags but I was told this is not something people use in general and it is more of a debugging/profiling aid for v8 developers. A command line flag does not solve all the issues as we want some of the options to be set on an Isolate specific fashion. Considering that we are still discussing the various possibilities of passing options to an Isolate we should change the milestone of this to post M8. |
Issue #3092 has been merged into this issue. cc @iposva-google. |
Is this happening for 1.7 ? |
Removed this from the 1.7 milestone. |
Will not fix. |
Instead of DART_FLAGS or DART_PACKAGE_ROOT, we should use command line flags.
We'll need the editor to change appropriately.
The text was updated successfully, but these errors were encountered: