Skip to content

dart2js: consider letting MirrorsUsed metatarget "hit" things annotated with the type #13862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kasperl opened this issue Oct 7, 2013 · 3 comments
Labels
closed-invalid Closed as we don't believe the reported issue is generally actionable web-dart2js
Milestone

Comments

@kasperl
Copy link

kasperl commented Oct 7, 2013

Right now, if you use a metatarget for MirrorsUsed:

   @­MirrorsUsed(metaTarget: 'X')
   import 'dart:mirrors';

it doesn't apply to things annotated with the X type, but only things annotated with an instance of X. So in this case:

   @­X
   foo() { ... }

   @­X()
   bar() { ... }

we only consider the bar function as being "hit" by the metatarget specification. Maybe we should reconsider that.

@DartBot
Copy link

DartBot commented Oct 7, 2013

This comment was originally written by @seaneagan


looks like another symptom of issue #13582

@DartBot
Copy link

DartBot commented Nov 1, 2013

This comment was originally written by @seaneagan


Status:Invalid given issue #14647?

@kasperl
Copy link
Author

kasperl commented Nov 1, 2013

Yeah, this is invalid (for now). Thanks for noticing, Sean!


Added Invalid label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-invalid Closed as we don't believe the reported issue is generally actionable web-dart2js
Projects
None yet
Development

No branches or pull requests

2 participants