Skip to content

Watcher should use Directory.watch #14428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nex3 opened this issue Oct 25, 2013 · 10 comments
Closed

Watcher should use Directory.watch #14428

nex3 opened this issue Oct 25, 2013 · 10 comments
Assignees
@nex3
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug
Milestone
1.6

Comments

@nex3
Copy link
Member

nex3 commented Oct 25, 2013

The polling watcher is very inefficient and memory-hungry, and is likely contributing towards issue #13848. Now that dart:io exposes native watchers, we should use them where possible.
@nex3
Copy link
Member Author

nex3 commented Oct 25, 2013

Marked this as blocking #13848.

@nex3
Copy link
Member Author

nex3 commented Nov 11, 2013

r30081 adds support for [Directory.watch] on Linux, and r30168 adds it on Mac OS. Now only Windows remains.

@nex3
Copy link
Member Author

nex3 commented Jan 14, 2014

Added Accepted label.

@lrhn
Copy link
Member

lrhn commented Jan 14, 2014

Removed Area-Library label.
Added Area-Pkg label.

@anders-sandholm
Copy link
Contributor

Removed Library-Watcher label.
Added Pkg-Watcher label.

@munificent
Copy link
Member

Lowering the priority. The polling watcher doesn't use as much memory now. It would still be good to use the native watcher support, but it's not a burning issue.

Removed Type-Defect, Priority-High labels.
Added Type-Enhancement, Priority-Medium labels.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M8 milestone.
Added this to the 1.6 milestone.

@munificent
Copy link
Member

Marked this as being blocked by #19189.

@andersjohnsen
Copy link

Landed native watching for Windows in r36988 + followups. While there may still may be tweaks to be made, it passes all current tests.

Added Fixed label.

@nex3 nex3 added Type-Enhancement area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Jun 4, 2014
@nex3 nex3 self-assigned this Jun 4, 2014
@nex3 nex3 added this to the 1.6 milestone Jun 4, 2014
This was referenced Jun 3, 2015
Closed
Closed
Closed
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/tools#1685.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nex3 nex3

Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
1.6
Development

No branches or pull requests
8 participants
@nex3 @kevmoo @andersjohnsen @munificent @kasperl @anders-sandholm @lrhn @DartBot