Skip to content

Windows exit codes should be displayed as hex codes and decoded #15261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peter-ahe-google opened this issue Nov 22, 2013 · 5 comments
Closed
Assignees
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@peter-ahe-google
Copy link
Contributor

Windows exit codes are a 32-bit unsigned integer and frequently the MSB is set (I believe this happens when there is a crash). This means that reporting it as a signed value is confusing. See issue #15139.

Instead the signed value should follow the Windows convention of printing a 8 digit hex code, possibly prefixed by 0x to avoid confusion between Unix and Windows.

In addition, the test runner should attempt to decode the exit code using err.exe (http://www.microsoft.com/en-us/download/details.aspx?id=985). We should be able to ensure that err.exe is available on the build bots.

If err.exe isn't available, the test runner should suggest downloading it.

@ricowind
Copy link
Contributor

Is that a valid tool to run against other pieces of software than Exchange Server?


Set owner to @whesse.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@ricowind
Copy link
Contributor

+sgjesse, +ajohnsen
The exit code reported by IO on windows should probably be treated like a unsigned int

@ricowind
Copy link
Contributor

actually +sgjesse, +ajohnsen


cc @sgjesse.
cc @Skabet.

@sgjesse
Copy link
Contributor

sgjesse commented Nov 25, 2013

Removed Area-Infrastructure label.
Added Area-IO label.

@peter-ahe-google
Copy link
Contributor Author

I don't see how this is a dart:io issue. This is a bug about how a number is printed by our test infrastructure.

As far as I know, weather or not a number is printed in hexadecimal notation is a property of the test infrastructure, not dart:io.

It is possible that there is a related bug in dart:io.


Removed Area-IO label.
Added Area-Infrastructure label.

@peter-ahe-google peter-ahe-google added Type-Defect area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. labels Nov 26, 2013
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
@sortie sortie closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

6 participants