pub build: javascript lacks release information and sourceMappingURL

[kevmoo]

Using Pub version 1.1.0-edge.31027

But with the attached installed dependencies

I'm getting the map files generated, which is great, but I need to manually add sourceMappingURL at the bottom of the generated JS to get Chrome to see them

...also nice to have the compiler version at the top, but that's less important

---

Attachment:
pubspec.lock (2.37 KB)

[munificent]

Bouncing over to dart2js since this is a request to add something to the generated JS.

---

Removed Library-Barback label.
Added Area-Dart2JS label.

[kevmoo]

FYI: when I do a normal dart2js (even minimized) I still get the build info at the top and sourceMappingURL at the bottom.

Curious why the output from pub/barback would lack this.

Is it something w/ options passed (or not passed) into dart2js?

[peter-ahe-google]

Removed Area-Dart2JS label.
Added Area-Pub label.

[peter-ahe-google]

The user of the compiler library decides were to put the source maps. Consequently, the compiler library expects that the user appends the sourceMappingURL.

[munificent]

Consequently, the compiler library expects that the user appends the sourceMappingURL.

Ah, OK. We can handle that then. Thanks for clarifying!

[peter-ahe-google]

I should probably mention that this is the current behavior.

Right now, the compiler API uses a "CompilerOutputProvider" to return an EventSink<String>. It would make sense to change the API so that the compiler library also becomes aware of the URI corresponding to this EventSink so that it can information such as sourceMappingURL.

[peter-ahe-google]

Filed issue #15607.

[munificent]

Marked this as being blocked by #15607.

[munificent]

Removed Priority-Unassigned label.
Added Priority-Medium label.

[munificent]

Marked this as blocking #15829.

[nex3]

Issue #16472 has been merged into this issue.

[sethladd]

Can I ask us to consider this issue for Milestone 1.2? I'm trying to integrate pub serve into my workflow, but this bug makes it very hard to do so. Without source maps, debugging is very difficult. Thanks for the consideration!

[sethladd]

Also, trying to get a good mobile dev workflow, and pub serve could be a real win. But I extra-need source maps for mobile since we don't produce builds of Dartium for Android. :)

[nex3]

Seth: You might want to make this plea on issue #15607, since that's where work needs to happen to get this supported.

[sethladd]

Roger that, thanks for the pointer.

[peter-ahe-google]

Marked this as being blocked by #17259.
Unmarked this as being blocked by #15607.

[munificent]

Set owner to @munificent.
Added Started label.

[munificent]

This is fixed now.

It should work with both pub serve and pub build. Note that with pub build, you'll need to do --mode debug to get our Dart source files copied over to the build output where the browser can find them.

---

Added Fixed label.

[sethladd]

Thanks Bob!

[DartBot]

This issue has been moved to dart-lang/pub#765.