Skip to content

docgen / dartdoc-viewer: link static methods when referenced as default values #18266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue Apr 16, 2014 · 6 comments
Closed
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.

Comments

@DartBot
Copy link

DartBot commented Apr 16, 2014

This issue was originally filed by @seaneagan


For the following method:

min(Iterable iterable, {Comparator comparator = Comparable.compare});

Currently the docs just display the following unstyled text for the default value:

function(Comparable#compare)

It would be useful if it linked to the Comparable.compare docs instead, as references in docs do, with similar styling.

@DartBot
Copy link
Author

DartBot commented Apr 16, 2014

This comment was originally written by @seaneagan


"as references in doc comments do"

@iposva-google
Copy link
Contributor

Added Area-DartDocViewer, Triaged labels.

@kevmoo
Copy link
Member

kevmoo commented Apr 18, 2014

This is work on the docgen side


Removed Area-DartDocViewer label.
Added Area-Pkg, Pkg-DocGen labels.

@DartBot
Copy link
Author

DartBot commented Apr 22, 2014

This comment was originally written by @seaneagan


Actually, should have been more general. I would want to link to any public names referenced by the default value expression. Examples:

final Duration ANIM_DURATION_DEFAULT = const Duration(milliseconds: 500);
slideIn(Element el, {Duration duration : ANIM_DURATION_DEFAULT});
fadeIn(Element el, {Duration duration : ANIM_DURATION_DEFAULT});
// ...

addChild(Node child, [Node parent = const Node.root()]) // ...

rotate(num radians, {num min: -PI, max: PI}) // ...

@sethladd
Copy link
Contributor

Moved to dart-lang/dartdoc#97

@sethladd
Copy link
Contributor

Added MovedToGithub label.

@DartBot DartBot added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Jan 12, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.
Projects
None yet
Development

No branches or pull requests

4 participants