-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Pub run should support passing in flags to vm #19569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Relatively soon, I want pub run to change from spawning a process to spawning an isolate for the entrypoint being run. (See: https://code.google.com/p/dart/issues/detail?id=19438). If that happens, we wouldn't be able to have separate VM flags for the spawned app. Would it make sense to spawn the pub process itself with these settings? That would mean the user is also implicitly debugging pub. This could be good if they want to see what transformers are doing, but may be confusing otherwise. What do you think? cc @nex3. |
Added this to the 1.6 milestone. |
Removed this from the 1.6 milestone. |
I would also need this for the test runner to be able to gather code coverage data from tests. I guess that would still be OK with isolates though just a bit more handling/filtering to do. |
Does the test runner run via |
The test runner runs Standalone VM test (aka non Browser tests) using "pub run" and browser tests using "pub serve" that allows us to make sure eventual transformers are applied without having to run "pub build" first. |
By the way it would be great if we could also have "pub run" run the VM in un-checked mode (currently it always runs in checked mode). I'm asking about that here because it seem related (you could just make that a flag you optionally pass to the underlying VM) |
When we add support for this, we'll definitely allow explicit control of checked mode as well. |
Possibly blocked by https://code.google.com/p/dart/issues/detail?id=21791 ? |
This issue has been moved to dart-lang/pub#1018. |
A typical invocation of the vm to run command line apps from DartEditor would look like
dart --enable-checked-mode --debug:50677 --enable-vm-service:50678 --trace_service_pause_events --pause-isolates-on-start myapp.dart
and any other that the user may specify
DartEditor should be able to specify arguments to pass on to the vm when starting pub run from the editor.
The text was updated successfully, but these errors were encountered: