Adjust URL during inlining more selectively

[sigmundch]

The list indicates not just which attributes to filter, but on what elements:
https://code.google.com/p/dart/codesearch#dart/trunk/dart/pkg/polymer/lib/src/build/import_inliner.dart&l=406

The inliner works fine with normal DOM elements because those attributes are not used for other purposes, but if some custom element happens to use the same attribute names, we shouldn't try to fix it.

See discussion here:

https://groups.google.com/a/dartlang.org/d/msgid/web/6b798af4-d5d3-4825-8397-1fe8d6f786eb%40dartlang.org?utm_medium=email&utm_source=footer

[sigmundch]

Removed Pkg-Polymer label.
Added Pkg-PolymerBuild label.

[sigmundch]

Issue #18316 has been merged into this issue.

[sigmundch]

Set owner to @jakemac53.

[sigmundch]

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

[sigmundch]

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.

[sigmundch]

Added PolymerMilestone-Next label.

[sigmundch]

Removed Polymer-Milestone-Next label.

[sigmundch]

Issue #19826 has been merged into this issue.

[jakemac53]

r38097 changes this so it will only affect attributes on standard html elements.

---

Added Fixed label.

[DartBot]

This comment was originally written by [email protected]

---

I was experiencing the same exception when on polymer version >=0.11.0 <0.12.0. When using the version >=0.12.0 it works fine in Dartium, but throws a new exception in Chrome: "Uncaught TypeError: Cannot read property 'element' of undefined"

That is, after the fix, the code runs good in dartium but blows up in chrome after compiling the solution to java script.

By inspecting the element in chrome, I got:

'Resource interpreted as Script but transferred with MIME type application/dart'

With entry point (after a chain of anonymous functions):

  'isolate_helper.dart:97'

and the blow up at:

  'isolate_helper.dart:438'

I also got this message:

'flushing 26 elements' at 'polymer.js:26' (I don't have a clue to what that means)

Some more info:

If I create my polymer element (that itself depends on core icons) in the web-root directory, then everything works fine and out of the box with polymer version >=0.11.0 <0.12.0. If I move my element to a directory in the web-root directory (i.e. components), then the element blows up (as described by this thread). Upgrading to the new polymer version >=0.12.0 fixes the problem in dartium, but now it blows up in chrome (when compiled to java script).

[DartBot]

This comment was originally written by [email protected]

---

Further looking into the problem gives that no matter where I put my polymer element (web root or some folder under web root), it always blows up when running the code in chrome (that is, solution compiled to java script), polymer version >=0.12.0

[jakemac53]

Thanks for the report Jan, I am pretty sure this is related to issue #20336, and is not a direct consequence of the bug fix here. I will start looking into that shortly though , and follow up in that issue :).

[sigmundch]

Hey Jan - we recently fixed the bug related to "Cannot read property 'element' of undefined". The issue was a bug in how the "dart:js" was being compiled by dart2js (issue #20305).

The fix is already submitted and will be part of the next dev SDK release (1.6.0-dev.7.0), which I expect will be out today or tomorrow if all looks good. If you need to get past this issue in the meantime, there is a longer discussion and some workarounds described in issue #20280.

[DartBot]

This issue has been moved to dart-archive/polymer-dart#411.