Having to define analysis_options in every package is cumbersome.

[pylaligand]

My repository hosts 15+ Dart packages and defines one .analysis_options file at the root. It looks like that options file is ignored by Atom which shows me all sorts of lint warnings when the file only specifies a handful (and a manual run of dartanalyzer only shows those).

/cc @devoncarew

[devoncarew]

also cc @pq

[bwilkerson]

I believe the expectation is for each package to have its own options file, but it sounds like the options file is in the directory containing all of the packages. Is that true?

If so, does it work correctly (for one of the packages) if you copy the file to the root of the package?

[pylaligand]

Yes.

No.

[pq]

If so, does it work correctly (for one of the packages) if you copy the file to the root of the package?

No.

I'd like to try and reproduce this. Is your repo public?

[pylaligand]

It is not, but I can create one that reproduces the issue if that's helpful.

[pq]

That would be great. Thanks!

[pylaligand]

So I tried to put together a smaller repo exhibiting the issue, but while the options file does not get picked up if it is placed at the root of the project, it does work when copied to the root of the package.

I then went back to my repo, tried to restart analysis, restart Atom, but it still shows lints I'm not enabling either at the root of the project or the root of the package. As an example, I never set always_declare_return_types anywhere and yet I'm seeing plenty of "Declare method return types" infos in Atom.

Not sure where to go from here. Since we both work for Google, I guess I can add you to my repo.

[pq]

So I tried to put together a smaller repo exhibiting the issue, but while the options file does not get picked up if it is placed at the root of the project, it does work when copied to the root of the package.

Right. Another source for confusion. Options correspond to packages. We often talk as if projects and packages were synonymous when often they're not.

Not sure where to go from here. Since we both work for Google, I guess I can add you to my repo.

Awesome. Happy to look.

[pq]

I then went back to my repo, tried to restart analysis, restart Atom, but it still shows lints I'm not enabling either at the root of the project or the root of the package. As an example, I never set always_declare_return_types anywhere and yet I'm seeing plenty of "Declare method return types" infos in Atom.

On looking over the sources, I think I see (the other) source of confusion. What you're seeing are analysis options that are inherited from flutter, which identifies a number of analyses that get turned on for all clients.

cc @sethladd @Hixie

To summarize, I see two issues:

1. Having options defined in 15 packages is cumbersome.
2. Inheriting embedded options can be confusing.

[pylaligand]

I filed dart-atom/atom-flutter#62 for the Flutter part. Wanna keep this one open for issue 1?

[pq]

Great. Yep. I re-named it to reflect the new thrust. Thanks!

[pq]

Kicked off a doc to explore a proposal here. Thoughts welcome!

[bwilkerson]

@pylaligand Is this still an issue?

[pylaligand]

I don't think so.