Skip to content

Support loading files via non-file: URIs #27266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsmenon opened this issue Sep 6, 2016 · 6 comments
Closed

Support loading files via non-file: URIs #27266

vsmenon opened this issue Sep 6, 2016 · 6 comments
Labels
closed-obsolete Closed as the reported issue is no longer relevant dev-compiler-ux type-enhancement A request for a change that isn't a bug web-dev-compiler

Comments

@vsmenon
Copy link
Member

vsmenon commented Sep 6, 2016

From @nex3 on July 27, 2016 23:23

Currently the dev compiler only supports compiling sources with file: URIs. To match other implementations, it should support http:, https: and data: URIs as well.

This is blocking dart-lang/test#414, which needs to be able to compile from HTTP to support pub serve.

Copied from original issue: dart-archive/dev_compiler#609

@vsmenon vsmenon added web-dev-compiler P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug labels Sep 6, 2016
@vsmenon
Copy link
Member Author

vsmenon commented Sep 6, 2016

From @jmesserly on July 28, 2016 5:5

(marked P1 if it's a blocker)

I can see how data could work, but what is http(s) supposed to do for a command line compiler? I don't see any code in analyzer_cli for it, and none of those URI schemes seem to work for dartanalyzer (as far as I can tell). If there's some way to make this work in Analyzer I'm all for it. (And probably we should implement it in pkg:analyzer so DDC doesn't need custom logic, and all front ends can get the same URI support...)

@vsmenon
Copy link
Member Author

vsmenon commented Sep 6, 2016

From @jmesserly on July 28, 2016 5:7

Aside, the idea of a compiler needing to support HTTP is a bit crazy on principle :). But I can see how we got there with our crazy concurrency story :|

@vsmenon
Copy link
Member Author

vsmenon commented Sep 6, 2016

From @jmesserly on August 11, 2016 19:58

Hey @nex3 did you have thoughts on how we could support this? It didn't look like Analyzer has support for these URI schemes but I may have missed something.

@vsmenon
Copy link
Member Author

vsmenon commented Sep 6, 2016

From @nex3 on August 11, 2016 20:6

I don't really know the internals of analyzer that well... you may have to add support for other URI schemes in its code. Doesn't it have a fairly separate abstraction for reading inputs that you can hook into?

@vsmenon vsmenon added dev-compiler-ux and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Jan 6, 2017
@nex3
Copy link
Member

nex3 commented Jun 28, 2017

I believe this is no longer blocking test.

@jmesserly
Copy link

assuming stale. if we want other URI schemes in the future, we should start by making sure Analyzer/CFE support them. (DDC does not do file loading for Dart files, it relies on its front ends for URI resolution and loading)

@jmesserly jmesserly added the closed-obsolete Closed as the reported issue is no longer relevant label Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant dev-compiler-ux type-enhancement A request for a change that isn't a bug web-dev-compiler
Projects
None yet
Development

No branches or pull requests

3 participants