Skip to content

Implement strong mode least upper bound #27525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks
leafpetersen opened this issue Oct 6, 2016 · 9 comments
Closed
3 tasks

Implement strong mode least upper bound #27525

leafpetersen opened this issue Oct 6, 2016 · 9 comments
Assignees
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). language-strong-mode-polish

Comments

@leafpetersen
Copy link
Member

leafpetersen commented Oct 6, 2016

This is a tracking bug for implementing proper least upper bound (and greatest lower bound) for strong mode in Dart 1.5

@leafpetersen leafpetersen added the area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). label Oct 6, 2016
@leafpetersen leafpetersen added this to the 1.50 milestone Oct 6, 2016
@leafpetersen leafpetersen self-assigned this Oct 6, 2016
@floitschG
Copy link
Contributor

Status update:
This issue is mainly about speccing. We do have a solution, but there is room for improvement. Future changes could result in breakage, and it would be good if we were confident in the solution for 1.50.
This issue might slip for 1.50. Either, we would be stuck with the current (working but not perfect) solution, or we would need to do a breaking change for strong-mode users.

Plan:

  • Leaf (assigned) writes down an informal brief approach.
  • We will see if we can find someone to spec it out.

@leafpetersen
Copy link
Member Author

status: we should have a final decision this week, then will be ready for implementers. We are planning a pre-submit run to see if we can successfully eliminate the use of LUB from inference.

@mit-mit mit-mit added the area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). label Dec 14, 2016
@mit-mit
Copy link
Member

mit-mit commented Dec 14, 2016

I don't seen an update here since the "final decision this week" comment made almost a month ago/ Are we still pursuing this for 1.50, or should we punt it?

@mit-mit mit-mit changed the title Meta issue for tracking implementation of strong mode least upper bound Meta issue for implementation of strong mode least upper bound Dec 15, 2016
@leafpetersen leafpetersen removed this from the 1.50 milestone Dec 20, 2016
@leafpetersen
Copy link
Member Author

Removing from 1.5.

@jmesserly
Copy link

Should we merge #25821 into this issue?

@munificent munificent removed the area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). label Jul 11, 2018
@munificent munificent changed the title Meta issue for implementation of strong mode least upper bound Implement strong mode least upper bound Jul 11, 2018
@nex3
Copy link
Member

nex3 commented Jan 11, 2019

Did this get fixed?

@leafpetersen
Copy link
Member Author

We didn't find anything satisfactory before Dart 2 shipped. I'd still like to look for something better here, but it will be a breaking change. In any case, I don't think this issue is useful for tracking it.

@nex3
Copy link
Member

nex3 commented Jan 11, 2019

Where should I subscribe to get updates for whatever improvement ends up happening?

@leafpetersen
Copy link
Member Author

Added a backlog issue here to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). language-strong-mode-polish
Projects
None yet
Development

No branches or pull requests

6 participants