Skip to content

Performance of command line dart with new front-end running dart programs is acceptable #28088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zanderso opened this issue Dec 13, 2016 · 7 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-vm front-end-kernel legacy-area-front-end Legacy: Use area-dart-model instead. P2 A bug or feature request we're likely to work on type-performance Issue relates to performance or code size
Milestone

Comments

@zanderso
Copy link
Member

@mhausner @a-siva @sigmundch Please populate this issue with performance targets for specific benchmarks.

@zanderso zanderso added area-kernel area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-performance Issue relates to performance or code size labels Dec 13, 2016
@zanderso zanderso added this to the 2.0 milestone Dec 13, 2016
@zanderso
Copy link
Member Author

zanderso commented Jan 7, 2017

Friendly ping. Please fill in targets here. @johnmccutchan

@johnmccutchan
Copy link
Contributor

$ time dart hw.dart
hello world

real	0m0.139s
user	0m0.130s
sys	0m0.035s

@fsc8000
Copy link
Contributor

fsc8000 commented Jan 10, 2017

More importantly, larger apps should perform equally well:

$ time out/ReleaseX64/dart-sdk/bin/dart2js ~/examples/hello.dart 

real	0m0.553s
user	0m0.506s
sys	0m0.233s

@johnmccutchan
Copy link
Contributor

@fsc8000 I agree your number is better.

@johnmccutchan
Copy link
Contributor

johnmccutchan commented Jan 10, 2017

Here is dart2js being run from source on a Z840.

$ time ./out/ReleaseX64/dart pkg/compiler/lib/src/dart2js.dart ~/hw.dart 

real	0m2.518s
user	0m3.010s
sys	0m0.463s

@rmacnak-google
Copy link
Contributor

#28585 (Kernel front-end increases memory footprint by over 5x)

@kmillikin kmillikin added P2 A bug or feature request we're likely to work on customer-vm labels Jan 5, 2018
@mraleph
Copy link
Member

mraleph commented Apr 24, 2018

I am closing this issue as not actionable. We are in progress of switching irrespective of current performance characteristics - which means we deemed the performance acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-vm front-end-kernel legacy-area-front-end Legacy: Use area-dart-model instead. P2 A bug or feature request we're likely to work on type-performance Issue relates to performance or code size
Projects
None yet
Development

No branches or pull requests

6 participants