Skip to content

make frontend strong clean #28673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 10 tasks
sigmundch opened this issue Feb 7, 2017 · 2 comments
Closed
1 of 10 tasks

make frontend strong clean #28673

sigmundch opened this issue Feb 7, 2017 · 2 comments
Labels
legacy-area-front-end Legacy: Use area-dart-model instead. P2 A bug or feature request we're likely to work on

Comments

@sigmundch
Copy link
Member

sigmundch commented Feb 7, 2017

This is a meta-bug to track what needs to be done to make package:front_end strong clean.

General errors pending to be fixed in package:front_end:

  • Incorrect type annotations
  • Covariant overrides
  • Covariant closures to forEach
  • Downcast composite warnings

Issues that should be fixed in the language:

This CL will fix the first 3 and temporarily ignore all the downcast composite warnings. The downward composite warnings are clearly cases that will fail at runtime in strong mode, so we can't ignore them indefinitely. There are a few changes that will help fix them:

  • add generics to stack_listener push pop and popList
  • avoid union types:
    • split optional arguments as a separate stack entry (see outline_builder)
    • see if we can flatten nested statement blocks differently (see body_builder).

We are delaying those changes until we set up some infrastructure that lets us track if those changes have any visible runtime performance effect.

@sigmundch sigmundch added the legacy-area-front-end Legacy: Use area-dart-model instead. label Feb 7, 2017
@kasperl
Copy link

kasperl commented Apr 20, 2017

Fields are now virtual by defaults and the composite downcast warnings are opt-in.

@jensjoha jensjoha added the P2 A bug or feature request we're likely to work on label Jan 8, 2018
@mraleph
Copy link
Member

mraleph commented Jun 25, 2024

I am pretty sure this is done by now.

@mraleph mraleph closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy-area-front-end Legacy: Use area-dart-model instead. P2 A bug or feature request we're likely to work on
Projects
None yet
Development

No branches or pull requests

4 participants