Skip to content

requestAnimationFrame callback with "double" not "int" value #2894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue May 4, 2012 · 6 comments
Closed

requestAnimationFrame callback with "double" not "int" value #2894

DartBot opened this issue May 4, 2012 · 6 comments
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue

Comments

@DartBot
Copy link

DartBot commented May 4, 2012

This issue was originally filed by @bp74


What steps will reproduce the problem?

  1. Call window.requestAnimationFrame(onAnimationFrame);
  2. Method: bool onAnimationFrame(int time)

What is the expected output? What do you see instead?

The time argument should be an integer, but starting with the latest Dartium Build it is a double value.
The value is somthing like "9059.999999939464".

What version of the product are you using? On what operating system?

Dart Editor 7313 32 bit, Windows 7 64 bit

@DartBot
Copy link
Author

DartBot commented May 4, 2012

This comment was originally written by @bp74


Sorry i was wrong, i checked the source of the SDK:
typedef bool RequestAnimationFrameCallback(num highResTime);

It is a num, not an int!

But the documentation is still wrong, it says "int time".
http://api.dartlang.org/html/RequestAnimationFrameCallback.html

@DartBot
Copy link
Author

DartBot commented May 4, 2012

This comment was originally written by [email protected]


Added Area-DOM, Triaged labels.

@DartBot
Copy link
Author

DartBot commented May 12, 2012

This comment was originally written by @bp74


The documentation says "num highResTime" now.

Maybe someone should check the specification if it says that a double value is valid or it should be an int. I havn't found it ...

@DartBot
Copy link
Author

DartBot commented May 23, 2012

This comment was originally written by @bp74


I just saw a new post on html5rocks:
RequestAnimationFrame with sub-millisecond precision.

http://updates.html5rocks.com/2012/05/requestAnimationFrame-API-now-with-sub-millisecond-precision

So it is clear that the time is a double. Please close the issue.

@DartBot
Copy link
Author

DartBot commented May 30, 2012

This comment was originally written by @bp74


Okay we are back to "int time" ...
I will stay with "num time" and i should be save.

@DartBot
Copy link
Author

DartBot commented Jun 1, 2012

This comment was originally written by [email protected]


Bernhard, we just follow WebKit here: it first switched to doubles in IDL and then reverted the change back, see http://trac.webkit.org/log/trunk/Source/WebCore/dom/RequestAnimationFrameCallback.idl

Sorry, I cannot fix it just for Dartium. If you prefer, you can probably file a bug against WebKit, but I assume this topic is actively discussed these days.


Added WontFix label.

@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue
Projects
None yet
Development

No branches or pull requests

2 participants